From: Bryan Wu <cooloney@kernel.org>
To: bigeasy@linutronix.de, linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Michael Hennerich <michael.hennerich@analog.com>,
Bryan Wu <cooloney@kernel.org>
Subject: [PATCH] USB/ISP1760: Fix for unaligned exceptions
Date: Tue, 18 Nov 2008 17:22:11 +0800 [thread overview]
Message-ID: <1227000131-19145-1-git-send-email-cooloney@kernel.org> (raw)
From: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Bryan Wu <cooloney@kernel.org>
---
drivers/usb/host/isp1760-hcd.c | 67 ++++++++++++++++++++++++++++-----------
1 files changed, 48 insertions(+), 19 deletions(-)
diff --git a/drivers/usb/host/isp1760-hcd.c b/drivers/usb/host/isp1760-hcd.c
index 8017f1c..00bece2 100644
--- a/drivers/usb/host/isp1760-hcd.c
+++ b/drivers/usb/host/isp1760-hcd.c
@@ -136,12 +136,21 @@ static void priv_read_copy(struct isp1760_hcd *priv, u32 *src,
return;
}
- while (len >= 4) {
- *src = __raw_readl(dst);
- len -= 4;
- src++;
- dst++;
- }
+ if (unlikely((u32)src & 0x3)) {
+ while (len >= 4) {
+ put_unaligned(__raw_readl(dst), src);
+ len -= 4;
+ src++;
+ dst++;
+ }
+ } else {
+ while (len >= 4) {
+ *src = __raw_readl(dst);
+ len -= 4;
+ src++;
+ dst++;
+ }
+ }
if (!len)
return;
@@ -159,25 +168,45 @@ static void priv_read_copy(struct isp1760_hcd *priv, u32 *src,
len--;
buff8++;
}
+
}
static void priv_write_copy(const struct isp1760_hcd *priv, const u32 *src,
__u32 __iomem *dst, u32 len)
{
- while (len >= 4) {
- __raw_writel(*src, dst);
- len -= 4;
- src++;
- dst++;
- }
- if (!len)
- return;
- /* in case we have 3, 2 or 1 by left. The buffer is allocated and the
- * extra bytes should not be read by the HW
- */
-
- __raw_writel(*src, dst);
+ if (unlikely((u32)src & 0x3)) {
+ while (len >= 4) {
+ __raw_writel(get_unaligned(src), dst);
+ len -= 4;
+ src++;
+ dst++;
+ }
+
+ if (!len)
+ return;
+ /* in case we have 3, 2 or 1 by left. The buffer is allocated and the
+ * extra bytes should not be read by the HW
+ */
+
+ __raw_writel(get_unaligned(src), dst);
+
+ } else{
+ while (len >= 4) {
+ __raw_writel(*src, dst);
+ len -= 4;
+ src++;
+ dst++;
+ }
+
+ if (!len)
+ return;
+ /* in case we have 3, 2 or 1 by left. The buffer is allocated and the
+ * extra bytes should not be read by the HW
+ */
+
+ __raw_writel(*src, dst);
+ }
}
/* memory management of the 60kb on the chip from 0x1000 to 0xffff */
--
1.5.6.3
next reply other threads:[~2008-11-18 9:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-18 9:22 Bryan Wu [this message]
2008-11-18 10:52 ` [PATCH] USB/ISP1760: Fix for unaligned exceptions Sebastian Andrzej Siewior
2008-11-18 15:41 ` Hennerich, Michael
2008-11-19 9:18 ` Sebastian Andrzej Siewior
2008-11-19 10:30 ` Hennerich, Michael
2008-11-19 10:55 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227000131-19145-1-git-send-email-cooloney@kernel.org \
--to=cooloney@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox