From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@liux-foundation.org>,
James Morris <jmorris@namei.org>,
Christoph Hellwig <hch@infradead.org>,
Al Viro <viro@ZenIV.linux.org.uk>,
David Safford <safford@watson.ibm.com>,
Serge Hallyn <serue@linux.vnet.ibm.com>,
Mimi Zohar <zohar@us.ibm.com>
Subject: Re: [PATCH 2/4] integrity: Linux Integrity Module(LIM)
Date: Fri, 21 Nov 2008 09:46:43 -0800 [thread overview]
Message-ID: <1227289603.11607.38.camel@nimitz> (raw)
In-Reply-To: <ece5bb6863d9b42016860f3ef78656e4a228ad95.1227137423.git.zohar@linux.vnet.ibm.com>
On Thu, 2008-11-20 at 11:43 -0500, Mimi Zohar wrote:
>
> + rcu_read_lock();
> + rc = integrity_find_template(template_name, &template_entry);
> + if (rc == 0)
> + tget(template_entry);
> + rcu_read_unlock();
This little nugget is repeated over and over. How about an
integrity_find_get_template()?
-- Dave
next prev parent reply other threads:[~2008-11-21 17:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-20 16:43 [PATCH 0/4] integrity Mimi Zohar
2008-11-20 16:43 ` [PATCH 1/4] integrity: TPM internel kernel interface Mimi Zohar
2008-11-20 16:43 ` [PATCH 2/4] integrity: Linux Integrity Module(LIM) Mimi Zohar
2008-11-20 17:45 ` Christoph Hellwig
2008-11-20 19:21 ` david safford
2008-11-20 19:26 ` Christoph Hellwig
2008-11-21 12:37 ` david safford
2008-11-21 17:45 ` Dave Hansen
2008-11-21 17:46 ` Dave Hansen [this message]
2008-11-21 19:10 ` Mimi Zohar
2008-11-21 17:48 ` Dave Hansen
2008-11-21 19:09 ` Mimi Zohar
2008-11-21 17:53 ` Dave Hansen
2008-11-21 19:10 ` Mimi Zohar
2008-11-20 16:43 ` [PATCH 3/4] integrity: IMA as an integrity service provider Mimi Zohar
2008-11-20 18:15 ` Christoph Hellwig
2008-11-20 20:52 ` Mimi Zohar
2008-11-21 1:42 ` Mimi Zohar
2008-11-20 21:22 ` Dave Hansen
2008-11-21 1:39 ` Mimi Zohar
2008-11-21 17:38 ` Dave Hansen
2008-11-20 16:43 ` [PATCH 4/4] integrity: replace task uid with cred uid Mimi Zohar
2008-11-21 17:42 ` [PATCH 0/4] integrity Dave Hansen
-- strict thread matches above, loose matches on Subject: below --
2008-11-13 3:47 Mimi Zohar
2008-11-13 3:47 ` [PATCH 2/4] integrity: Linux Integrity Module(LIM) Mimi Zohar
2008-11-14 22:15 ` Andrew Morton
2008-11-17 19:04 ` Mimi Zohar
2008-11-17 16:05 ` Christoph Hellwig
2008-11-17 19:09 ` Mimi Zohar
2008-11-18 13:29 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227289603.11607.38.camel@nimitz \
--to=dave@linux.vnet.ibm.com \
--cc=akpm@liux-foundation.org \
--cc=hch@infradead.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=safford@watson.ibm.com \
--cc=serue@linux.vnet.ibm.com \
--cc=viro@ZenIV.linux.org.uk \
--cc=zohar@linux.vnet.ibm.com \
--cc=zohar@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox