From: Steven Rostedt <srostedt@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
Peter Teoh <htmldeveloper@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing: allow tracing of suspend/resume & hibernation code again
Date: Mon, 24 Nov 2008 16:43:05 -0500 [thread overview]
Message-ID: <1227562985.7622.5.camel@localhost.localdomain> (raw)
In-Reply-To: <20081123094124.GO30453@elte.hu>
On Sun, 2008-11-23 at 10:41 +0100, Ingo Molnar wrote:
> * Rafael J. Wysocki <rjw@sisk.pl> wrote:
>
> > > Q2: how to ftrace s2ram and resume? I attempted to do it, but the
> > > trace output is always filled with "resume" related functions when
> > > it started up, which is only logical.
> >
> > The tracing is disabled during suspend/resume, so you can't.
>
> i think we could lift this restriction now that dftrace is gone for
> good - which was causing most of the trouble.
The suspend resume problem did not happen with the dtrace. But whenever
there is a trace happening. It would fail with the stack tracer on with
the static function tracer.
The problem is that there are several functions in resume that are
called without first setting up smp_processor_id(). That is, if you
call smp_processor_id() it will crash the system. The function tracer
uses smp_processor_id() to stop recursion (per_cpu disabled variable).
Anything that actually tries to use the ring buffer will also crash,
since it too will use smp_processor_id to find the per cpu ring buffer
to write to.
-- Steve
>
> 41108eb10142e0552f2de1e4c0675b108c5f018f
> f42ac38c59e0a03d6da0c24a63fb211393f484b0
>
> Completely untested patch below. Peter, does it work for you?
>
next prev parent reply other threads:[~2008-11-24 21:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-22 8:47 Some FTRACE related question Peter Teoh
2008-11-22 12:59 ` Rafael J. Wysocki
2008-11-23 9:41 ` [PATCH] tracing: allow tracing of suspend/resume & hibernation code again Ingo Molnar
2008-11-23 15:37 ` Peter Teoh
2008-11-24 15:47 ` Peter Teoh
2008-12-10 3:09 ` Peter Teoh
2008-11-24 21:43 ` Steven Rostedt [this message]
2008-11-22 13:30 ` Some FTRACE related question Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227562985.7622.5.camel@localhost.localdomain \
--to=srostedt@redhat.com \
--cc=htmldeveloper@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox