Re: [PATCH] lro: IP fragment checking

Andrew Gallatin
2008-12-01T17:50:42Z

Jan-Bernd Themann wrote:
> This patch prevents that ip fragmented TCP packets are considered vaild
> for aggregation

<...>

> + if (iph->frag_off & IP_MF)
> + return -1;
> +

I think there is an endian bug, and that you should also check
IP_OFFSET. What about:

if (iph->frag_off & htons(IP_MF|IP_OFFSET))

As to whether or not to do it in the drivers/hardware or in the
LRO code, I favor doing it in the LRO code just so that it is not
missed in some driver.

Drew