From: Richard Purdie <rpurdie@rpsys.net>
To: Guennadi Liakhovetski <lg@denx.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: leds/leds-pca9532.c: sleeping function called in .brightness_set()
Date: Wed, 03 Dec 2008 10:03:27 +0000 [thread overview]
Message-ID: <1228298607.9126.1.camel@ted> (raw)
In-Reply-To: <Pine.LNX.4.64.0811241041130.4148@axis700.grange>
On Mon, 2008-11-24 at 10:51 +0100, Guennadi Liakhovetski wrote:
> this seems to explicitly violate the API as documented in
> include/linux/leds.h:
>
> /* Set LED brightness level */
> /* Must not sleep, use a workqueue if needed */
> void (*brightness_set)(struct led_classdev *led_cdev,
> enum led_brightness brightness);
>
> and also contradicts some other drivers, e.g., pca955x, which do use a
> workqueue as suggested: leds-pca9532.c::pca9532_set_brightness uses a
> mutex for locking and calls i2c_smbus functions directly. Needs to be
> fixed (if it hasn't been fixed yet), probably, also vor 2.6.27-stable.
There is a patch queued to fix this now. I'll submit some fixes to
2.6.28-rcX shortly and then we can consider it for -stable.
Cheers,
Richard
--
Richard Purdie
Intel Open Source Technology Centre
prev parent reply other threads:[~2008-12-03 10:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 9:51 leds/leds-pca9532.c: sleeping function called in .brightness_set() Guennadi Liakhovetski
2008-12-03 10:03 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228298607.9126.1.camel@ted \
--to=rpurdie@rpsys.net \
--cc=lg@denx.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox