From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752049AbYLCK2F (ORCPT ); Wed, 3 Dec 2008 05:28:05 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751288AbYLCK1y (ORCPT ); Wed, 3 Dec 2008 05:27:54 -0500 Received: from viefep18-int.chello.at ([213.46.255.22]:48409 "EHLO viefep18-int.chello.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751204AbYLCK1W (ORCPT ); Wed, 3 Dec 2008 05:27:22 -0500 X-SourceIP: 213.46.9.244 Subject: Re: [PATCH 2/2] tracing/function-graph-tracer: improve duration output From: Peter Zijlstra To: =?ISO-8859-1?Q?Fr=E9d=E9ric?= Weisbecker Cc: Ingo Molnar , Steven Rostedt , Tim Bird , Linux Kernel In-Reply-To: References: <4935E19C.3090501@gmail.com> <4935E226.3060906@gmail.com> <20081203081906.GH21006@elte.hu> <20081203083332.GA5455@elte.hu> <1228299706.9673.115.camel@twins> Content-Type: text/plain; charset="UTF-8" Date: Wed, 03 Dec 2008 11:27:06 +0100 Message-Id: <1228300026.9673.122.camel@twins> Mime-Version: 1.0 X-Mailer: Evolution 2.24.1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2008-12-03 at 11:23 +0100, Frédéric Weisbecker wrote: > 2008/12/3 Peter Zijlstra : > > On Wed, 2008-12-03 at 11:07 +0100, Frédéric Weisbecker wrote: > >> > >> > >> > > >> > btw., i tested the graph tracer on a 16-way 64-bit box as well, and > >> the > >> > multi-digit CPU field printout magic works fine there too: > >> > > >> > 9) | pick_next_task() { > >> > 9) 0.283 us | pick_next_task_fair(); > >> > 9) 0.276 us | pick_next_task_rt(); > >> > 9) 0.273 us | pick_next_task_fair(); > >> > 9) 0.279 us | pick_next_task_idle(); > >> > 9) 2.596 us | } > >> > 9) 0.566 us | __lock_text_start(); > >> > 10) 0.299 us | } > >> > 10) | mm_init() { > >> > 10) | pgd_alloc() { > >> > 10) | __get_free_pages() { > >> > 10) | alloc_pages_current() { > >> > 10) 0.330 us | policy_zonelist(); > >> > 10) | __alloc_pages_internal() { > >> > > >> > Ingo > >> > > >> > >> Hmm not really, there should be one space more before the 9 to fit the > >> log10(MAX_CPU) here and not break > >> the column. > > > > It did in my copy of Ingo's email... > > > So perhaps I should drop gmail...... :-( I've been told that gmail has ways of extracting email through POP3. Perhaps that manages to preserve layout.. if not, I'll file a bug with google and get a real mail account pronto :-)