From: Matt Mackall <mpm@selenic.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] shmem: unify regular and tiny shmem
Date: Fri, 05 Dec 2008 12:15:36 -0600 [thread overview]
Message-ID: <1228500936.3255.210.camel@calx> (raw)
In-Reply-To: <Pine.LNX.4.64.0812051311530.10157@blonde.anvils>
On Fri, 2008-12-05 at 13:18 +0000, Hugh Dickins wrote:
> I agree with where you're going (surrendering your empire to mine!
> or perhaps you don't you see it quite that way?), but I think this
> isn't quite the patch you meant to send: it shouldn't contain that
>
> > - &shmem_file_operations);
> > + &shmem_file_operations);
> > +
> > +#ifndef CONFIG_MMU
> > + error = ramfs_nommu_expand_for_mapping(inode, size);
> > + if (error)
> > + goto close_file;
> > +#endif
>
> hunk in mm/shmem.c
I'm staring at the source and I'm at a loss as to why not? SHMEM depends
on MMU, so this only gets done when !SHMEM && !MMU, which makes it the
same as the tiny-shmem.c code it's unifying, no?
> and it should be deleting mm/tiny-shmem.c?
Not sure how that bit fell off, yes.
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2008-12-05 18:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-04 21:19 [PATCH] shmem: unify regular and tiny shmem Matt Mackall
2008-12-05 13:18 ` Hugh Dickins
2008-12-05 18:15 ` Matt Mackall [this message]
2008-12-05 22:21 ` Hugh Dickins
2008-12-05 22:43 ` Matt Mackall
2008-12-05 22:51 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228500936.3255.210.camel@calx \
--to=mpm@selenic.com \
--cc=akpm@linux-foundation.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox