Re: [PATCH 5/6] kvm-s390: use register_virtio_root_device()

Christian Borntraeger
2008-12-11T09:06:14Z

Am Mittwoch, 10. Dezember 2008 schrieb Mark McLoughlin:
> This is basically a no-op change, since it does exactly the
> same thing as s390_root_dev_register() when the caller isn't
> a module.

Ok, I gave it a short test and it seems to work.
Some comments: I agree with your comment in patch0, that a generic
device_register_root() function might be useful.

> --- a/drivers/s390/kvm/kvm_virtio.c
> +++ b/drivers/s390/kvm/kvm_virtio.c
[...]
> - kvm_root = s390_root_dev_register("kvm_s390");
> + kvm_root = register_virtio_root_device("kvm_s390");
[...]
> - s390_root_dev_unregister(kvm_root);
> + unregister_virtio_root_device(kvm_root);

You can now remove the include <asm/s390_rdev.h>