From: john stultz <johnstul@us.ibm.com>
To: Dimitri Sivanich <sivanich@sgi.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 2/2 v4] SGI RTC: add clocksource driver
Date: Fri, 05 Dec 2008 14:09:53 -0800 [thread overview]
Message-ID: <1228514994.21144.3.camel@localhost.localdomain> (raw)
In-Reply-To: <20081124195810.GB8387@sgi.com>
On Mon, 2008-11-24 at 13:58 -0600, Dimitri Sivanich wrote:
> This patch provides a driver for SGI RTC clocks and timers.
>
> This provides a high resolution clock and timer source using the SGI
> system-wide synchronized RTC clock/timer hardware.
>
> Signed-off-by: Dimitri Sivanich <sivanich@sgi.com>
>
> ---
>
> Changed the shift values for clocksource and clockevent.
> Made other stylistic changes.
>
[snip]
> +static struct clocksource clocksource_uv = {
> + .name = RTC_NAME,
> + .rating = 400,
> + .read = uv_read_rtc,
> + .mask = (cycle_t)UVH_RTC_REAL_TIME_CLOCK_MASK,
> + .shift = 10,
> + .flags = CLOCK_SOURCE_IS_CONTINUOUS,
> +};
Hey Dimitri,
Sorry for being slow to catch this. This address my earlier concerns.
Thanks!
Acked-by: John Stultz <johnstul@us.ibm.com>
-john
prev parent reply other threads:[~2008-12-05 22:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 19:54 [PATCH 0/2 v4] SGI RTC: add clocksource/clockevent driver and generic timer vector Dimitri Sivanich
2008-11-24 19:56 ` [PATCH 1/2 v4] SGI RTC: add generic timer system interrupt Dimitri Sivanich
2008-11-24 19:58 ` [PATCH 2/2 v4] SGI RTC: add clocksource driver Dimitri Sivanich
2008-12-05 22:09 ` john stultz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228514994.21144.3.camel@localhost.localdomain \
--to=johnstul@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sivanich@sgi.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox