Re: [PATCH] virtio: make PCI devices take a virtio_pci module ref

Mark McLoughlin
2008-12-05T18:38:18Z

On Fri, 2008-12-05 at 09:43 -0600, Anthony Liguori wrote:
> Mark McLoughlin wrote:
> > On Fri, 2008-12-05 at 14:17 +0100, Jiri Slaby wrote:
> >
> > +static void virtio_pci_release_dev(struct device *dev)
> > +{
> > +}
> > +
> > /* A PCI device has it's own struct device and so does a virtio device so
> > * we create a place for the virtio devices to show up in sysfs. I think it
> > * would make more sense for virtio to not insist on having it's own device. */
> > static struct device virtio_pci_root = {
> > .parent = NULL,
> > .bus_id = "virtio-pci",
> > + .release = virtio_pci_release_dev,
> > };
> >
>
> Actually, we should be able to delete this virtio_pci_root entirely.
> The device is a dummy one anyway.

Care to recall why it was added initially and what's changed?

One side effect of removing it is that each device appears on its own
in /sys/devices rather than neatly under /sys/devices/virtio-pci.

(And one side effect of that is that the aforementioned Fedora mkinitrd
kludge stops working which would make me sad :-)

Cheers,
mark.