From: Robert Richter <robert.richter@amd.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: oprofile-list <oprofile-list@lists.sourceforge.net>,
Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
Robert Richter <robert.richter@amd.com>
Subject: [PATCH 3/9] oprofile: adding cpu_buffer_entries()
Date: Thu, 11 Dec 2008 17:41:57 +0100 [thread overview]
Message-ID: <1229013723-8191-4-git-send-email-robert.richter@amd.com> (raw)
In-Reply-To: <1229013723-8191-1-git-send-email-robert.richter@amd.com>
This is in preparation for changes in the cpu buffer implementation.
Signed-off-by: Robert Richter <robert.richter@amd.com>
---
drivers/oprofile/buffer_sync.c | 31 ++-----------------------------
drivers/oprofile/cpu_buffer.h | 27 +++++++++++++++++++++++++++
2 files changed, 29 insertions(+), 29 deletions(-)
diff --git a/drivers/oprofile/buffer_sync.c b/drivers/oprofile/buffer_sync.c
index 44f676c..aed286c 100644
--- a/drivers/oprofile/buffer_sync.c
+++ b/drivers/oprofile/buffer_sync.c
@@ -464,33 +464,6 @@ static inline int is_code(unsigned long val)
}
-/* "acquire" as many cpu buffer slots as we can */
-static unsigned long get_slots(struct oprofile_cpu_buffer *b)
-{
- unsigned long head = b->head_pos;
- unsigned long tail = b->tail_pos;
-
- /*
- * Subtle. This resets the persistent last_task
- * and in_kernel values used for switching notes.
- * BUT, there is a small window between reading
- * head_pos, and this call, that means samples
- * can appear at the new head position, but not
- * be prefixed with the notes for switching
- * kernel mode or a task switch. This small hole
- * can lead to mis-attribution or samples where
- * we don't know if it's in the kernel or not,
- * at the start of an event buffer.
- */
- cpu_buffer_reset(b);
-
- if (head >= tail)
- return head - tail;
-
- return head + (b->buffer_size - tail);
-}
-
-
/* Move tasks along towards death. Any tasks on dead_tasks
* will definitely have no remaining references in any
* CPU buffers at this point, because we use two lists,
@@ -576,11 +549,11 @@ void sync_buffer(int cpu)
/* Remember, only we can modify tail_pos */
#ifndef CONFIG_OPROFILE_IBS
- available = get_slots(cpu_buf);
+ available = cpu_buffer_entries(cpu_buf);
for (i = 0; i < available; ++i) {
#else
- while (get_slots(cpu_buf)) {
+ while (cpu_buffer_entries(cpu_buf)) {
#endif
struct op_sample *s = cpu_buffer_read_entry(cpu_buf);
diff --git a/drivers/oprofile/cpu_buffer.h b/drivers/oprofile/cpu_buffer.h
index e608976..6055b56 100644
--- a/drivers/oprofile/cpu_buffer.h
+++ b/drivers/oprofile/cpu_buffer.h
@@ -81,6 +81,33 @@ struct op_sample *cpu_buffer_read_entry(struct oprofile_cpu_buffer *cpu_buf)
return &cpu_buf->buffer[cpu_buf->tail_pos];
}
+/* "acquire" as many cpu buffer slots as we can */
+static inline
+unsigned long cpu_buffer_entries(struct oprofile_cpu_buffer *b)
+{
+ unsigned long head = b->head_pos;
+ unsigned long tail = b->tail_pos;
+
+ /*
+ * Subtle. This resets the persistent last_task
+ * and in_kernel values used for switching notes.
+ * BUT, there is a small window between reading
+ * head_pos, and this call, that means samples
+ * can appear at the new head position, but not
+ * be prefixed with the notes for switching
+ * kernel mode or a task switch. This small hole
+ * can lead to mis-attribution or samples where
+ * we don't know if it's in the kernel or not,
+ * at the start of an event buffer.
+ */
+ cpu_buffer_reset(b);
+
+ if (head >= tail)
+ return head - tail;
+
+ return head + (b->buffer_size - tail);
+}
+
/* transient events for the CPU buffer -> event buffer */
#define CPU_IS_KERNEL 1
#define CPU_TRACE_BEGIN 2
--
1.6.0.1
next prev parent reply other threads:[~2008-12-11 16:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-11 16:41 [PATCH 0/9] oprofile: port to the new ring buffer Robert Richter
2008-12-11 16:41 ` [PATCH 1/9] oprofile: adding cpu buffer r/w access functions Robert Richter
2008-12-11 16:41 ` [PATCH 2/9] oprofile: adding cpu_buffer_write_commit() Robert Richter
2008-12-11 16:41 ` Robert Richter [this message]
2008-12-11 16:41 ` [PATCH 4/9] oprofile: moving cpu_buffer_reset() to cpu_buffer.h Robert Richter
2008-12-11 16:41 ` [PATCH 5/9] ring_buffer: add remaining cpu functions to ring_buffer.h Robert Richter
2008-12-11 19:23 ` Steven Rostedt
2008-12-11 16:42 ` [PATCH 6/9] oprofile: port to the new ring_buffer Robert Richter
2008-12-11 19:48 ` Steven Rostedt
2008-12-16 17:23 ` Robert Richter
2008-12-16 19:38 ` Steven Rostedt
2008-12-16 9:37 ` Andrew Morton
2008-12-11 16:42 ` [PATCH 7/9] oprofile: remove nr_available_slots() Robert Richter
2008-12-11 16:42 ` [PATCH 8/9] oprofile: fix lost sample counter Robert Richter
2008-12-11 16:42 ` [PATCH 9/9] ring_buffer: adding EXPORT_SYMBOLs Robert Richter
2008-12-11 17:19 ` [PATCH 0/9] oprofile: port to the new ring buffer Steven Rostedt
2008-12-12 5:57 ` Ingo Molnar
2008-12-16 23:49 ` Andrew Morton
2008-12-17 5:03 ` Pekka Enberg
2008-12-22 23:53 ` Carl Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1229013723-8191-4-git-send-email-robert.richter@amd.com \
--to=robert.richter@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oprofile-list@lists.sourceforge.net \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox