From: Eric Paris <eparis@redhat.com>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: linux-audit@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 9/15] sanitize audit_fd_pair()
Date: Wed, 17 Dec 2008 12:18:32 -0500 [thread overview]
Message-ID: <1229534312.3384.11.camel@localhost.localdomain> (raw)
In-Reply-To: <E1LCohy-0000De-Tc@ZenIV.linux.org.uk>
On Wed, 2008-12-17 at 05:12 +0000, Al Viro wrote:
> * no allocations
> * return void
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> diff --git a/kernel/auditsc.c b/kernel/auditsc.c
> index ac89cd3..5de0087 100644
> --- a/kernel/auditsc.c
> +++ b/kernel/auditsc.c
> @@ -215,6 +210,7 @@ struct audit_context {
> struct mq_attr attr;
> } mq_open;
> };
> + int fds[2];
>
> #if AUDIT_DEBUG
> int put_count;
Waste of space, at least on a 32 bit machine where the size of the ipc
aux data is definitely larger than the sockcall aux data. But I guess
what you did is a whole lot easier and clearer than to try to hack up
adding it to both sockcall and new pipe_fds and using the right one at
the right time. I guess if we cared about 64 bits per audited thread we
wouldn't be moving the aux data into the audit_context anyway.
Acked-by: Eric Paris <eparis@redhat.com>
prev parent reply other threads:[~2008-12-17 17:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-17 5:12 [PATCH 9/15] sanitize audit_fd_pair() Al Viro
2008-12-17 7:42 ` James Morris
2008-12-17 17:18 ` Eric Paris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1229534312.3384.11.camel@localhost.localdomain \
--to=eparis@redhat.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox