public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: "Serge E. Hallyn" <serue@us.ibm.com>
Cc: Linux Containers <containers@lists.osdl.org>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] mqueue ns: move mqueue_mnt into struct ipc_namespace
Date: Wed, 17 Dec 2008 10:55:54 -0800	[thread overview]
Message-ID: <1229540154.17206.428.camel@nimitz> (raw)
In-Reply-To: <20081217185241.GA25250@us.ibm.com>

On Wed, 2008-12-17 at 12:52 -0600, Serge E. Hallyn wrote:
> > > +void mq_init_ns(struct ipc_namespace *ns) {
> > > +   ns->mq_queues_count  = 0;
> > > +   ns->mq_queues_max    = DFLT_QUEUESMAX;
> > > +   ns->mq_msg_max       = DFLT_MSGMAX;
> > > +   ns->mq_msgsize_max   = DFLT_MSGSIZEMAX;
> > > +   ns->mq_mnt           = mntget(init_ipc_ns.mq_mnt);
> > > +}
> > 
> > Heh, I read that as a structure definition at first!  Could you put
> that
> > bracket on a new line.
> 
> That's actually taken care of in the followup patch - same with
> mq_exit_ns.  Sorry about that.  (Still I'd rather not bother with
> the patch flux to change it just in this patch, since whenever
> I do that I inevitably mess up something else)

Ahh, ok.  I guess it is OK since it is temporary.

-- Dave


  reply	other threads:[~2008-12-17 18:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-17 17:55 [RFC patch 0/2] posix mqueue namespace (v12) Serge E. Hallyn
2008-12-17 17:55 ` [PATCH 1/2] mqueue ns: move mqueue_mnt into struct ipc_namespace Serge E. Hallyn
2008-12-17 18:36   ` Dave Hansen
2008-12-17 18:52     ` Serge E. Hallyn
2008-12-17 18:55       ` Dave Hansen [this message]
2008-12-17 17:55 ` [PATCH 2/2] ipc namespaces: implement support for posix msqueues Serge E. Hallyn
2008-12-17 18:54   ` Dave Hansen
2008-12-17 19:08     ` Serge E. Hallyn
2008-12-17 21:25   ` Sukadev Bhattiprolu
2008-12-18 21:36     ` Serge E. Hallyn
2008-12-17 17:57 ` [LTP PATCH 1/4] posix message queue namespaces: first test Serge E. Hallyn
2008-12-17 17:57 ` [LTP PATCH 2/4] posix mqns: test parent to child mq access Serge E. Hallyn
2008-12-17 17:58 ` [LTP PATCH 3/4] posix mqns: test vfs and mq interaction Serge E. Hallyn
2008-12-17 17:58 ` [LTP PATCH 4/4] posix mqns: test that user mount of posixmq survivies the ipcns Serge E. Hallyn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1229540154.17206.428.camel@nimitz \
    --to=dave@linux.vnet.ibm.com \
    --cc=containers@lists.osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=serue@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox