Re: [PATCH] sys_execve and sys_uselib do not call into fsnotify

KOSAKI Motohiro
2008-12-18T02:39:42Z

> On Wed, 17 Dec 2008 13:53:20 -0500
> Eric Paris <eparis@redhat.com> wrote:
>
> > sys_execve and sys_uselib do not call into fsnotify so inotify does not get
> > open events for these types of syscalls. This patch simply makes the
> > requisite fsnotify calls.
>
> These two functions are grovelling around in pretty low-level fs
> operations. One wonders whether they could be converted (ie: cleaned
> up) to use do_sys_open() or some other such higher-level thing.
>
> That way, this fsnotify bug would be magically fixed, too.

hmm..

In current implementaion, do_sys_open() call fd_install().
then, it cause /proc/{pid}/fd entry change. iow, compatibility break.

Yup, it is fixable. but I think Eric's implementation is simpler.