Re: [PATCH] sys_execve and sys_uselib do not call into fsnotify

Frederik Deweerdt
2008-12-17T22:52:48Z

On Wed, Dec 17, 2008 at 02:22:21PM -0500, Eric Paris wrote:
> On Wed, 2008-12-17 at 20:04 +0100, Frederik Deweerdt wrote:
> > Just curious, isn't the fact that the open still may fail a problem?
> > For example, if the lib is not executable in sys_uselib or if the file
> > was denied write access in open_exec.
>
> I could be convinced to change it but like what I have. At this point
> the file is open. If it fails after this we are going to call fput()
> which calls __fput() which calls fsnotify_close(). Seemed odd to leave
> a close without an open (although that's what we have today.)
>
> This doesn't mean the syscall was successful, but the file was opened,
> and it will be closed....
OK, thanks for clarifying,

Frederik