From: Matt Mackall <mpm@selenic.com>
To: David Miller <davem@davemloft.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: [PATCH] Stop scaring users with "treason uncloaked!"
Date: Thu, 18 Dec 2008 16:16:21 -0600 [thread overview]
Message-ID: <1229638581.3726.546.camel@calx> (raw)
These debug messages are uninformative and extremely alarming. Rather
than reporting a peer as a treacherous attacker, report it more
correctly as simply broken.
Signed-off-by: Matt Mackall <mpm@selenic.com>
diff -r 320a7bd38b8d net/ipv4/tcp_timer.c
--- a/net/ipv4/tcp_timer.c Mon Oct 27 17:33:24 2008 -0500
+++ b/net/ipv4/tcp_timer.c Thu Dec 18 16:06:39 2008 -0600
@@ -299,14 +299,14 @@
#ifdef TCP_DEBUG
struct inet_sock *inet = inet_sk(sk);
if (sk->sk_family == AF_INET) {
- LIMIT_NETDEBUG(KERN_DEBUG "TCP: Treason uncloaked! Peer " NIPQUAD_FMT ":%u/%u shrinks window %u:%u. Repaired.\n",
+ LIMIT_NETDEBUG(KERN_DEBUG "TCP: Broken peer " NIPQUAD_FMT ":%u/%u shrinks window %u:%u. Repaired.\n",
NIPQUAD(inet->daddr), ntohs(inet->dport),
inet->num, tp->snd_una, tp->snd_nxt);
}
#if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
else if (sk->sk_family == AF_INET6) {
struct ipv6_pinfo *np = inet6_sk(sk);
- LIMIT_NETDEBUG(KERN_DEBUG "TCP: Treason uncloaked! Peer " NIP6_FMT ":%u/%u shrinks window %u:%u. Repaired.\n",
+ LIMIT_NETDEBUG(KERN_DEBUG "TCP: Broken peer " NIP6_FMT ":%u/%u shrinks window %u:%u. Repaired.\n",
NIP6(np->daddr), ntohs(inet->dport),
inet->num, tp->snd_una, tp->snd_nxt);
}
--
Mathematics is the supreme nostalgia of our time.
next reply other threads:[~2008-12-18 22:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-18 22:16 Matt Mackall [this message]
2008-12-18 22:33 ` [PATCH] Stop scaring users with "treason uncloaked!" Ilpo Järvinen
2008-12-18 22:36 ` Herbert Xu
2008-12-18 23:50 ` Matt Mackall
2008-12-19 0:15 ` David Miller
2008-12-19 3:49 ` Matt Mackall
2008-12-19 3:54 ` David Miller
2008-12-19 18:13 ` markus reichelt
2008-12-19 0:08 ` David Miller
2008-12-18 22:44 ` Herbert Xu
2008-12-18 22:49 ` Alan Cox
2008-12-18 23:02 ` Herbert Xu
2008-12-18 23:14 ` Alan Cox
2008-12-19 0:07 ` David Miller
2008-12-18 23:06 ` Matt Mackall
2008-12-19 0:45 ` David Schwartz
2008-12-19 0:55 ` Krzysztof Halasa
2008-12-19 0:58 ` Rick Jones
2009-01-26 17:46 ` Lennart Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1229638581.3726.546.camel@calx \
--to=mpm@selenic.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox