Re: [PATCH] Stop scaring users with "treason uncloaked!"

Ilpo Järvinen
2008-12-18T22:34:01Z

On Thu, 18 Dec 2008, Matt Mackall wrote:

> These debug messages are uninformative and extremely alarming. Rather
> than reporting a peer as a treacherous attacker, report it more
> correctly as simply broken.

Last time (well, ignoring some report on ancient vendor kernel) I've seen
this to trigger it wasn't the fault of the peer but ours (we sent past the
advertized window and window ended up being shrunk to zero). I agree that
the message as-is is not very good but your change is not very good
either.

> - LIMIT_NETDEBUG(KERN_DEBUG "TCP: Treason uncloaked! Peer " NIPQUAD_FMT ":%u/%u shrinks window %u:%u. Repaired.\n",
> + LIMIT_NETDEBUG(KERN_DEBUG "TCP: Broken peer " NIPQUAD_FMT ":%u/%u shrinks window %u:%u. Repaired.\n",

This won't apply to net-next on which you should base anything new (and
net related).

--
i.