public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Carl Love <cel@us.ibm.com>
To: Robert Richter <robert.richter@amd.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
	Steven Rostedt <rostedt@goodmis.org>,
	oprofile-list <oprofile-list@lists.sourceforge.net>
Subject: Re: [PATCH 0/9] oprofile: port to the new ring buffer
Date: Mon, 22 Dec 2008 15:53:39 -0800	[thread overview]
Message-ID: <1229990019.13485.0.camel@carll-linux-desktop> (raw)
In-Reply-To: <1229013723-8191-1-git-send-email-robert.richter@amd.com>

I have tested  the new ring buffer patches on an IBM Cell blade.  Our
OProfile testsuite ran fine on the the patched kernel. I ran the
testsuite three times yesterday/last night.  As far as I can tell
the new code works fine.

Note, I started with a 2.6.28-rc7 kernel from kernel.org.  I then
applied the the ftrace series of patches followed by the ring buffer
patches.  I then had to explicitly enable the tracing in the .config
file as there is now a dependency on that.  Robert updated the OProfile
dependency stuff yesterday.  I started with my .config file that I have
used for building kernels on my cell machine.

                       Carl Love

On Thu, 2008-12-11 at 17:41 +0100, Robert Richter wrote:
> This patch set ports cpu buffers in oprofile to the new ring buffer
> provided by the tracing framework. The motivation here is to leave the
> pain of implementing ring buffers to others. Oh, no, there are more
> advantages. Main reason is the support of different sample sizes that
> could be stored in the buffer. Use cases for this are IBS and Cell spu
> profiling. Using the new ring buffer ensures valid and complete
> samples and allows copying the cpu buffer stateless without knowing
> its content. Second it will use generic kernel API and also reduce
> code size. And hopefully, there are less bugs.
> 
> The patch set is also available here:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git ring_buffer
> 
> -Robert
> 
> 
> 
> 
> ------------------------------------------------------------------------------
> SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
> The future of the web can't happen without you.  Join us at MIX09 to help
> pave the way to the Next Web now. Learn more and register at
> http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
> _______________________________________________
> oprofile-list mailing list
> oprofile-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/oprofile-list


      parent reply	other threads:[~2008-12-22 23:54 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-11 16:41 [PATCH 0/9] oprofile: port to the new ring buffer Robert Richter
2008-12-11 16:41 ` [PATCH 1/9] oprofile: adding cpu buffer r/w access functions Robert Richter
2008-12-11 16:41 ` [PATCH 2/9] oprofile: adding cpu_buffer_write_commit() Robert Richter
2008-12-11 16:41 ` [PATCH 3/9] oprofile: adding cpu_buffer_entries() Robert Richter
2008-12-11 16:41 ` [PATCH 4/9] oprofile: moving cpu_buffer_reset() to cpu_buffer.h Robert Richter
2008-12-11 16:41 ` [PATCH 5/9] ring_buffer: add remaining cpu functions to ring_buffer.h Robert Richter
2008-12-11 19:23   ` Steven Rostedt
2008-12-11 16:42 ` [PATCH 6/9] oprofile: port to the new ring_buffer Robert Richter
2008-12-11 19:48   ` Steven Rostedt
2008-12-16 17:23     ` Robert Richter
2008-12-16 19:38       ` Steven Rostedt
2008-12-16  9:37   ` Andrew Morton
2008-12-11 16:42 ` [PATCH 7/9] oprofile: remove nr_available_slots() Robert Richter
2008-12-11 16:42 ` [PATCH 8/9] oprofile: fix lost sample counter Robert Richter
2008-12-11 16:42 ` [PATCH 9/9] ring_buffer: adding EXPORT_SYMBOLs Robert Richter
2008-12-11 17:19 ` [PATCH 0/9] oprofile: port to the new ring buffer Steven Rostedt
2008-12-12  5:57 ` Ingo Molnar
2008-12-16 23:49 ` Andrew Morton
2008-12-17  5:03   ` Pekka Enberg
2008-12-22 23:53 ` Carl Love [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1229990019.13485.0.camel@carll-linux-desktop \
    --to=cel@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oprofile-list@lists.sourceforge.net \
    --cc=robert.richter@amd.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox