Re: [PATCH] sh: maple: add support for Maple controller as a joystick

Adrian McMenamin
2008-12-26T19:09:36Z

On Tue, 2008-12-23 at 03:59 -0500, Dmitry Torokhov wrote:
> On Mon, Dec 22, 2008 at 05:07:35PM -0800, Harvey Harrison wrote:
> > On Mon, 2008-12-22 at 15:06 -0800, Andrew Morton wrote:
> > > On Fri, 19 Dec 2008 23:15:42 +0000
> > > Adrian McMenamin <adrian@newgolddream.dyndns.info> wrote:
> > >
> > > > Not sure what happened with earlier submissions, so here is an up-to-date
> > > > patch for the Dreamcast Maple controlled.
> > > >
> > > >
> > > > Add support for the SEGA Dreamcast Maple controller as a joystick
> > > >
> > > > ...
> > > >
> > > > +static void dc_pad_callback(struct mapleq *mq)
> > > > +{
> > > > + unsigned short buttons;
> > > > + struct maple_device *mapledev = mq->dev;
> > > > + struct dc_pad *pad = maple_get_drvdata(mapledev);
> > > > + struct input_dev *dev = pad->dev;
> > > > + unsigned char *res = mq->recvbuf;
> > > > +
> > > > + buttons = ~cpu_to_le16(*(unsigned short *)(res + 8));
> > >
> > > hm, could that be simplified?
> >
> > And as a bonus fix the obvious sparse warning:
> >
> > buttons = ~le16_to_cpup((__le16 *)(res + 8));
> >
>
> Below is what I woudl like to apply unless you see more issues with the
> patch. Andrew, if you could test it on your hardware to make sure it
> still works that woudl be great.
>
> Thanks!
>

Just to say I've tested this with jstest now and it seems to be in good
working order. There is a calibration issue on one axis, but I think
that's my hardware :-)