From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754245AbYL2Vp7 (ORCPT ); Mon, 29 Dec 2008 16:45:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752909AbYL2Vpt (ORCPT ); Mon, 29 Dec 2008 16:45:49 -0500 Received: from accolon.hansenpartnership.com ([76.243.235.52]:58256 "EHLO accolon.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752280AbYL2Vps (ORCPT ); Mon, 29 Dec 2008 16:45:48 -0500 Subject: Re: linux-next: Tree for December 29 (fcoe) From: James Bottomley To: Randy Dunlap Cc: Stephen Rothwell , scsi , linux-next@vger.kernel.org, LKML In-Reply-To: <1230586520.3302.61.camel@localhost.localdomain> References: <20081230031621.60acd90b.sfr@canb.auug.org.au> <20081229123115.9a255fa8.randy.dunlap@oracle.com> <1230586520.3302.61.camel@localhost.localdomain> Content-Type: text/plain Date: Mon, 29 Dec 2008 15:45:41 -0600 Message-Id: <1230587141.3302.64.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 (2.22.3.1-1.fc9) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2008-12-29 at 15:35 -0600, James Bottomley wrote: > On Mon, 2008-12-29 at 12:31 -0800, Randy Dunlap wrote: > > On Tue, 30 Dec 2008 03:16:21 +1100 Stephen Rothwell wrote: > > > > > Hi all, > > > > > > Changes since 20081219: > > > > > > Undropped tree: > > > scci > > > mtd > > > > > > Dropped trees (temporarily): > > > nfs (akpm request due to 2.6.30 features) > > > kvm (build problem) > > > rr (build poblem) > > > semaphore-removal (due to unfixed conflicts against Linus' tree) > > > cpu_alloc (build problem) > > > audit (difficult conflicts) > > > > > > Linus' tree had three build failures requiring patches and one requiring > > > a revert. > > > > > > linux-next-20081229/drivers/scsi/fcoe/libfcoe.c:995: error: dereferencing pointer to incomplete type > > linux-next-20081229/drivers/scsi/fcoe/libfcoe.c:1015: error: dereferencing pointer to incomplete type > > > > (on netdev->name ?) > > This looks a bit odd. libfcoe.h #includes linux/netdevice.h which > defines the structure ... I can't see how netdev could have an > incomplete type. Could you make libfcoe.i and see what's happening? Actually, I deduce the problem is owner->name and your build has CONFIG_MODULE=n ... the definition of struct module is enclosed in a #ifdef CONFIG_MODULE. This should fix it. James --- diff --git a/drivers/scsi/fcoe/libfcoe.c b/drivers/scsi/fcoe/libfcoe.c index 1cb549c..fec38f6 100644 --- a/drivers/scsi/fcoe/libfcoe.c +++ b/drivers/scsi/fcoe/libfcoe.c @@ -992,7 +992,7 @@ static int fcoe_ethdrv_get(const struct net_device *netdev) owner = fcoe_netdev_to_module_owner(netdev); if (owner) { printk(KERN_DEBUG "foce:hold driver module %s for %s\n", - owner->name, netdev->name); + module_name(owner), netdev->name); return try_module_get(owner); } return -ENODEV; @@ -1012,7 +1012,7 @@ static int fcoe_ethdrv_put(const struct net_device *netdev) owner = fcoe_netdev_to_module_owner(netdev); if (owner) { printk(KERN_DEBUG "foce:release driver module %s for %s\n", - owner->name, netdev->name); + module_name(owner), netdev->name); module_put(owner); return 0; }