From: Harvey Harrison <harvey.harrison@gmail.com>
To: Tom Spink <tspink@gmail.com>
Cc: Jesper Juhl <jj@chaosbits.net>, Ingo Brueckl <ib@wupperonline.de>,
linux-kernel@vger.kernel.org
Subject: Re: compile time warnings
Date: Thu, 01 Jan 2009 17:39:40 -0800 [thread overview]
Message-ID: <1230860380.5500.1.camel@brick> (raw)
In-Reply-To: <7b9198260901011735k42e9298tb1c5dc0e15285eb1@mail.gmail.com>
On Fri, 2009-01-02 at 01:35 +0000, Tom Spink wrote:
> 2009/1/1 Jesper Juhl <jj@chaosbits.net>:
> > On Thu, 1 Jan 2009, Ingo Brueckl wrote:
> [snip]
>
> Hi,
>
> > pgd_base is very much used...
>
> It's probably something to do with:
>
> # define permanent_kmaps_init(pgd_base) do { } while (0)
>
> Which is within the #else part of #if CONFIG_HIGHMEM. So, if
> CONFIG_HIGHMEM is not set, permanent_kmaps_init gets wiped out, and
> therefore that warning will be issued.
>
> Perhaps changing that to an empty inline would remove the warning?
>
If it can be an inline, it should be, otherwise:
# define permanent_kmaps_init(pgd_base) do { (void)(pgd_base) } while (0)
would do the trick.
Harvey
next prev parent reply other threads:[~2009-01-02 1:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-01 21:13 compile time warnings Ingo Brueckl
2009-01-01 22:52 ` Jesper Juhl
2009-01-02 1:35 ` Tom Spink
2009-01-02 1:39 ` Harvey Harrison [this message]
2009-01-02 2:07 ` Jesper Juhl
2009-01-02 9:57 ` Ingo Molnar
2009-01-02 12:53 ` [PATCH] " Ingo Brueckl
2009-01-02 13:01 ` Ingo Molnar
2009-01-02 13:42 ` Ingo Brueckl
2009-01-02 14:42 ` Ingo Molnar
2009-01-02 16:07 ` Jesper Juhl
2009-01-02 16:10 ` Jesper Juhl
2009-01-02 2:48 ` Ingo Brueckl
2009-01-02 20:03 ` Robert Hancock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1230860380.5500.1.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=ib@wupperonline.de \
--cc=jj@chaosbits.net \
--cc=linux-kernel@vger.kernel.org \
--cc=tspink@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox