* [PATCH 09/23] sparc: introduce asm/swab.h
@ 2009-01-06 21:30 Harvey Harrison
2009-01-06 22:04 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Harvey Harrison @ 2009-01-06 21:30 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Andrew Morton, David Miller, LKML
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
Dave, I would have rather moved the SWAB_64_THRU_32 bit to the
top of swab.h like all other arches, but I kept it a pure movement patch.
It seems to make sense for sparc the way it is however, just FYI.
arch/sparc/include/asm/Kbuild | 1 +
arch/sparc/include/asm/byteorder.h | 46 +----------------------------------
arch/sparc/include/asm/swab.h | 45 +++++++++++++++++++++++++++++++++++
3 files changed, 48 insertions(+), 44 deletions(-)
diff --git a/arch/sparc/include/asm/Kbuild b/arch/sparc/include/asm/Kbuild
index 58f9b3a..d012070 100644
--- a/arch/sparc/include/asm/Kbuild
+++ b/arch/sparc/include/asm/Kbuild
@@ -23,3 +23,4 @@ header-y += traps.h
header-y += uctx.h
header-y += utrap.h
header-y += watchdog.h
+header-y += swab.h
diff --git a/arch/sparc/include/asm/byteorder.h b/arch/sparc/include/asm/byteorder.h
index 738414b..48a047c 100644
--- a/arch/sparc/include/asm/byteorder.h
+++ b/arch/sparc/include/asm/byteorder.h
@@ -1,49 +1,7 @@
#ifndef _SPARC_BYTEORDER_H
#define _SPARC_BYTEORDER_H
-#include <linux/types.h>
-#include <asm/asi.h>
-
-#define __BIG_ENDIAN
-
-#if defined(__sparc__) && defined(__arch64__)
-static inline __u16 __arch_swab16p(const __u16 *addr)
-{
- __u16 ret;
-
- __asm__ __volatile__ ("lduha [%1] %2, %0"
- : "=r" (ret)
- : "r" (addr), "i" (ASI_PL));
- return ret;
-}
-#define __arch_swab16p __arch_swab16p
-
-static inline __u32 __arch_swab32p(const __u32 *addr)
-{
- __u32 ret;
-
- __asm__ __volatile__ ("lduwa [%1] %2, %0"
- : "=r" (ret)
- : "r" (addr), "i" (ASI_PL));
- return ret;
-}
-#define __arch_swab32p __arch_swab32p
-
-static inline __u64 __arch_swab64p(const __u64 *addr)
-{
- __u64 ret;
-
- __asm__ __volatile__ ("ldxa [%1] %2, %0"
- : "=r" (ret)
- : "r" (addr), "i" (ASI_PL));
- return ret;
-}
-#define __arch_swab64p __arch_swab64p
-
-#else
-#define __SWAB_64_THRU_32__
-#endif /* defined(__sparc__) && defined(__arch64__) */
-
-#include <linux/byteorder.h>
+#include <asm/swab.h>
+#include <linux/byteorder/big_endian.h>
#endif /* _SPARC_BYTEORDER_H */
diff --git a/arch/sparc/include/asm/swab.h b/arch/sparc/include/asm/swab.h
new file mode 100644
index 0000000..a34ad07
--- /dev/null
+++ b/arch/sparc/include/asm/swab.h
@@ -0,0 +1,45 @@
+#ifndef _SPARC_SWAB_H
+#define _SPARC_SWAB_H
+
+#include <linux/types.h>
+#include <asm/asi.h>
+
+#if defined(__sparc__) && defined(__arch64__)
+static inline __u16 __arch_swab16p(const __u16 *addr)
+{
+ __u16 ret;
+
+ __asm__ __volatile__ ("lduha [%1] %2, %0"
+ : "=r" (ret)
+ : "r" (addr), "i" (ASI_PL));
+ return ret;
+}
+#define __arch_swab16p __arch_swab16p
+
+static inline __u32 __arch_swab32p(const __u32 *addr)
+{
+ __u32 ret;
+
+ __asm__ __volatile__ ("lduwa [%1] %2, %0"
+ : "=r" (ret)
+ : "r" (addr), "i" (ASI_PL));
+ return ret;
+}
+#define __arch_swab32p __arch_swab32p
+
+static inline __u64 __arch_swab64p(const __u64 *addr)
+{
+ __u64 ret;
+
+ __asm__ __volatile__ ("ldxa [%1] %2, %0"
+ : "=r" (ret)
+ : "r" (addr), "i" (ASI_PL));
+ return ret;
+}
+#define __arch_swab64p __arch_swab64p
+
+#else
+#define __SWAB_64_THRU_32__
+#endif /* defined(__sparc__) && defined(__arch64__) */
+
+#endif /* _SPARC_SWAB_H */
--
1.6.1.94.g9388
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 09/23] sparc: introduce asm/swab.h
2009-01-06 21:30 [PATCH 09/23] sparc: introduce asm/swab.h Harvey Harrison
@ 2009-01-06 22:04 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-01-06 22:04 UTC (permalink / raw)
To: harvey.harrison; +Cc: torvalds, akpm, linux-kernel
From: Harvey Harrison <harvey.harrison@gmail.com>
Date: Tue, 06 Jan 2009 13:30:50 -0800
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
> Dave, I would have rather moved the SWAB_64_THRU_32 bit to the
> top of swab.h like all other arches, but I kept it a pure movement patch.
>
> It seems to make sense for sparc the way it is however, just FYI.
Ok.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-06 22:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-06 21:30 [PATCH 09/23] sparc: introduce asm/swab.h Harvey Harrison
2009-01-06 22:04 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox