From: Matt Helsley <matthltc@us.ibm.com>
To: "Serge E. Hallyn" <serue@us.ibm.com>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
Linux Containers <containers@lists.linux-foundation.org>,
linux-nfs@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Trond Myklebust <trond.myklebust@fys.uio.no>,
Chuck Lever <chuck.lever@oracle.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Linux Containers <containers@lists.osdl.org>,
Cedric Le Goater <clg@fr.ibm.com>
Subject: Re: [RFC][PATCH 2/4] sunrpc: Use utsnamespaces
Date: Tue, 06 Jan 2009 15:35:23 -0800 [thread overview]
Message-ID: <1231284923.14345.158.camel@localhost> (raw)
In-Reply-To: <20090106215324.GD18147@us.ibm.com>
On Tue, 2009-01-06 at 15:53 -0600, Serge E. Hallyn wrote:
> Quoting J. Bruce Fields (bfields@fieldses.org):
> > On Tue, Jan 06, 2009 at 02:02:29PM -0600, Serge E. Hallyn wrote:
> > > Quoting Matt Helsley (matthltc@us.ibm.com):
> > > > We can often specify the UTS namespace to use when starting an RPC client.
> > > > However sometimes no UTS namespace is available (specifically during system
> > > > shutdown as the last NFS mount in a container is unmounted) so fall
> > > > back to the initial UTS namespace.
> > >
> > > So what happens if we take this patch and do nothing else?
> > >
> > > The only potential problem situation will be rpc requests
> > > made on behalf of a container in which the last task has
> > > exited, right? So let's say a container did an nfs mount
> > > and then exits, causing an nfs umount request.
> > >
> > > That umount request will now be sent with the wrong nodename.
> > > Does that actually cause problems, will the server use the
> > > nodename to try and determine the client sending the request?
> >
> > This is just the machine name in the auth_unix credential? The linux
> > server ignores that completely (for the purpose of auth_unix
> > authenication, it identifies clients only by source ip address). I
> > suspect other servers also ignore it, but I don't know.
>
> Thanks, that's what i was hoping...
>
> Matt, have you audited the other rpc-based services? Do any
> of them care?
Frankly, I did not audit any of the RPC-based services to see if any
truly cared about the node name. That's actually a rather large scope
when you consider it -- I'd have to look at much more than just "Linux"
RPC clients. It seemed unsafe to assume _nobody_ would care after they
bothered to put it into the spec.
Hopefully I'm wrong though :).
Cheers,
-Matt
next prev parent reply other threads:[~2009-01-06 23:35 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-06 1:13 [RFC][PATCH 0/4] utsns: RPC/NFS bug rework Matt Helsley
2009-01-06 1:13 ` [RFC][PATCH 1/4] Remove useless utsname.h includes Matt Helsley
2009-01-06 1:13 ` [RFC][PATCH 2/4] sunrpc: Use utsnamespaces Matt Helsley
2009-01-06 20:02 ` Serge E. Hallyn
2009-01-06 20:20 ` J. Bruce Fields
2009-01-06 21:53 ` Serge E. Hallyn
2009-01-06 23:35 ` Matt Helsley [this message]
2009-01-06 22:43 ` Matt Helsley
2009-01-06 20:44 ` Trond Myklebust
2009-01-06 21:58 ` Serge E. Hallyn
2009-01-06 22:42 ` Trond Myklebust
2009-01-07 0:08 ` Matt Helsley
2009-01-07 0:20 ` Trond Myklebust
2009-01-07 0:43 ` Matt Helsley
2009-01-07 1:10 ` Trond Myklebust
2009-01-07 0:20 ` J. Bruce Fields
2009-01-07 0:23 ` Trond Myklebust
2009-01-07 3:44 ` Matt Helsley
2009-01-06 23:04 ` Eric W. Biederman
2009-01-06 23:15 ` Trond Myklebust
2009-01-06 23:32 ` J. Bruce Fields
2009-01-06 23:35 ` Trond Myklebust
2009-01-06 23:48 ` Matt Helsley
2009-01-06 23:51 ` Chuck Lever
2009-01-06 23:53 ` J. Bruce Fields
2009-01-07 0:07 ` Matt Helsley
2009-01-07 0:55 ` Eric W. Biederman
2009-01-07 0:20 ` Trond Myklebust
2009-01-07 0:20 ` Trond Myklebust
2009-01-07 0:26 ` J. Bruce Fields
2009-01-07 0:38 ` Trond Myklebust
2009-01-07 1:44 ` J. Bruce Fields
2009-01-07 1:50 ` Trond Myklebust
2009-01-07 2:37 ` Eric W. Biederman
2009-01-06 23:30 ` Matt Helsley
2009-01-06 23:18 ` Matt Helsley
2009-01-06 23:43 ` Trond Myklebust
2009-01-06 23:58 ` Matt Helsley
2009-01-06 22:29 ` Chuck Lever
2009-01-07 0:01 ` Serge E. Hallyn
2009-01-06 1:13 ` [RFC][PATCH 3/4] sunrpc: Improve UTS namespace workaround Matt Helsley
2009-01-06 16:02 ` Chuck Lever
2009-01-07 0:28 ` Matt Helsley
2009-01-07 3:02 ` Matt Helsley
2009-01-06 1:13 ` [RFC][PATCH 4/4] Represent RPC Callers Matt Helsley
2009-01-06 13:04 ` Trond Myklebust
2009-01-06 23:05 ` Matt Helsley
-- strict thread matches above, loose matches on Subject: below --
2009-01-07 0:39 [RFC][PATCH 2/4] sunrpc: Use utsnamespaces trond.myklebust
2009-01-07 0:57 ` Matt Helsley
2009-01-07 1:02 ` Trond Myklebust
2009-01-07 1:22 ` Matt Helsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231284923.14345.158.camel@localhost \
--to=matthltc@us.ibm.com \
--cc=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=clg@fr.ibm.com \
--cc=containers@lists.linux-foundation.org \
--cc=containers@lists.osdl.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=serue@us.ibm.com \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox