Re: 2.6.29 -mm merge plans

Andrew Morton
2009-01-06T23:09:41Z

(cc added)

On Tue, 6 Jan 2009 17:57:44 -0500
Christoph Hellwig <hch@infradead.org> wrote:

> On Mon, Jan 05, 2009 at 12:43:00AM -0800, Andrew Morton wrote:
> > fs-truncate-blocks-outside-i_size-after-o_direct-write-error.patch
> > fs-truncate-blocks-outside-i_size-after-o_direct-write-error-fix.patch
>
> Btw, this code is still not quite right. We really need to call
> ->setattr instead of vmtruncate here. Complex filesystem need
> transaction to properly free blocks, and those transactions are in
> ->setattr not inside vmtruncate where ->truncate doesn't even have
> a chance to get the handle to the transaction passed.
>
> As these patches don't make it worse this is not a NACK, but more of
> a heads up.

Sure. Maybe add a FIXME comment for now?