Re: 2.6.29 -mm merge plans

Harvey Harrison
2009-01-07T00:16:37Z

On Wed, 2009-01-07 at 01:09 +0100, Diego E. 'Flameeyes' Pettenò wrote:
> On Tue, 2009-01-06 at 15:49 -0800, Harvey Harrison wrote:
> > One other nit, byteswap the constant so it can be done at compile-time:
> >
> I copied over the code from dir.c, so I've propagated the change to
> that, and also to super.c where a similar case was present, I'm
> attaching it at 0002 (but maybe it should go in before the NFS export
> support?).
>
> I've not checked if there are other cases where this can be optimised
> though, maybe I should.
>

Depending on how often they are used, perhaps just define those constants
directly as be values and get the cpu_to_beXX out of the codepaths. If
they're also used on cpu-endian values, this isn't so great...but I haven't
actually looked.

Cheers,

Harvey

> If you all are in mood of HFS+ patches review, I might try to run the
> code through a couple of my tools, I had in my TODO list to try them on
> kernel code for a while ;)
>

Feel free to send me whatever your most recent patchset is and I'll have a
look at it. (at least a good sparse-checkup)

Cheers,

Harvey