From: Harvey Harrison <harvey.harrison@gmail.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: powerpc: introduce asm/swab.h
Date: Tue, 06 Jan 2009 20:48:42 -0800 [thread overview]
Message-ID: <1231303722.14442.1.camel@brick> (raw)
In-Reply-To: <1231303340.14860.61.camel@pasglop>
On Wed, 2009-01-07 at 15:42 +1100, Benjamin Herrenschmidt wrote:
> On Wed, 2009-01-07 at 04:00 +0000, Linux Kernel Mailing List wrote:
> > Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=156ca2bbf6503a02d7d6829886ce381d572de66e
> > Commit: 156ca2bbf6503a02d7d6829886ce381d572de66e
> > Parent: 8cdd3a9261e8efe36aeb6c708edb76d7e2b5d13f
> > Author: Harvey Harrison <harvey.harrison@gmail.com>
> > AuthorDate: Tue Jan 6 14:56:23 2009 -0800
> > Committer: Linus Torvalds <torvalds@linux-foundation.org>
> > CommitDate: Tue Jan 6 18:10:27 2009 -0800
> >
> > powerpc: introduce asm/swab.h
> >
> > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> > Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
>
> Was this tested ? I see no arch maintainer signed-off here, it appears
> to at least break ppc32, and contains hunks that paulus says were
> explicitely nacked (removing of our ld_* macros) etc...
>
> Linus, please revert.
Please look a bit closer, it's a pure movement of code out of byteorder.h into swab.h,
no changes whatsoever.
Cheers,
Harvey
next prev parent reply other threads:[~2009-01-07 4:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200901070400.n0740Ore002063@hera.kernel.org>
2009-01-07 4:42 ` powerpc: introduce asm/swab.h Benjamin Herrenschmidt
2009-01-07 4:48 ` Harvey Harrison [this message]
2009-01-07 4:59 ` Nicolas Pitre
2009-01-07 5:08 ` Linus Torvalds
2009-01-07 5:12 ` Nicolas Pitre
2009-01-07 5:01 ` Linus Torvalds
2009-01-07 5:08 ` Nicolas Pitre
2009-01-07 5:02 ` Benjamin Herrenschmidt
2009-01-07 5:11 ` Linus Torvalds
2009-01-07 5:19 ` Nicolas Pitre
2009-01-07 5:26 ` Nicolas Pitre
2009-01-07 5:38 ` Linus Torvalds
2009-01-07 5:37 ` Linus Torvalds
2009-01-07 6:02 ` Harvey Harrison
2009-01-07 6:05 ` Benjamin Herrenschmidt
2009-01-07 5:39 ` Steven Rostedt
2009-01-07 5:43 ` Benjamin Herrenschmidt
2009-01-07 8:37 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231303722.14442.1.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox