From: "Duje Mihanović" <duje.mihanovic@skole.hr>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Russell King <linux@armlinux.org.uk>,
Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andy@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-input@vger.kernel.org,
linux-spi@vger.kernel.org
Subject: Re: [PATCH RFT v7 2/6] ARM: pxa: Convert Spitz LEDs to GPIO descriptors
Date: Tue, 10 Oct 2023 18:33:28 +0200 [thread overview]
Message-ID: <12313687.O9o76ZdvQC@radijator> (raw)
In-Reply-To: <CAMRc=Mc7=E9bMQgiUM8qqk7UD4+exhJZqw2DucTcsnqHcttR3Q@mail.gmail.com>
On Tuesday, October 10, 2023 1:12:05 PM CEST Bartosz Golaszewski wrote:
> Gah! I should have noticed this earlier but this is a perfect
> candidate for using hogs. Can you use gpiod_add_hogs() from
> linux/gpio/machine.h instead? That would save you having the lookup
> and the static leds descriptor array.
From what I can tell, the hogs keep a certain pin at a certain state as long
as the machine is powered on. Is this really what we want to do with LEDs or
am I missing something?
Regards,
Duje
next prev parent reply other threads:[~2023-10-10 16:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 18:33 [PATCH RFT v7 0/6] ARM: pxa: GPIO descriptor conversions Duje Mihanović
2023-10-09 18:33 ` [PATCH RFT v7 1/6] ARM: pxa: Convert Spitz OHCI to GPIO descriptors Duje Mihanović
2023-10-10 11:09 ` Bartosz Golaszewski
2023-10-09 18:33 ` [PATCH RFT v7 2/6] ARM: pxa: Convert Spitz LEDs " Duje Mihanović
2023-10-10 11:12 ` Bartosz Golaszewski
2023-10-10 16:33 ` Duje Mihanović [this message]
2023-10-10 17:39 ` Bartosz Golaszewski
2023-10-10 20:04 ` Linus Walleij
2023-10-11 7:59 ` Bartosz Golaszewski
2023-10-09 18:34 ` [PATCH RFT v7 3/6] ARM: pxa: Convert Spitz CF power control " Duje Mihanović
2023-10-09 18:34 ` [PATCH RFT v7 4/6] ARM: pxa: Convert reset driver " Duje Mihanović
2023-10-09 18:34 ` [PATCH RFT v7 5/6] ARM: pxa: Convert gumstix Bluetooth " Duje Mihanović
2023-10-09 18:34 ` [PATCH RFT v7 6/6] input: ads7846: Move wait_for_sync() logic to driver Duje Mihanović
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12313687.O9o76ZdvQC@radijator \
--to=duje.mihanovic@skole.hr \
--cc=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=daniel@zonque.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=haojian.zhuang@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=robert.jarzmik@free.fr \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox