From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: David <davem@davemloft.net>
Cc: andrew@lunn.ch, netdev <netdev@vger.kernel.org>,
sfeldma@gmail.com, jiri@resnulli.us,
Florian Fainelli <f.fainelli@gmail.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-kernel <linux-kernel@vger.kernel.org>,
kernel <kernel@savoirfairelinux.com>
Subject: Re: [PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit
Date: Thu, 9 Jul 2015 17:03:24 -0400 (EDT) [thread overview]
Message-ID: <1231604948.157146.1436475804451.JavaMail.zimbra@savoirfairelinux.com> (raw)
In-Reply-To: <20150709.110135.225522890258902682.davem@davemloft.net>
Hi David,
----- On Jul 9, 2015, at 2:01 PM, David davem@davemloft.net wrote:
> From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> Date: Wed, 8 Jul 2015 13:13:16 -0400 (EDT)
>
>> You're right. There's a single operation to clear the STU and VTU. I
>> will send a follow-up patch to send this command during the switch
>> setup.
>
> Fix known bugs in the patch series, within the patch series, since it
> hasn't been merged yet.
>
> Don't say "I'll fix this bug later", because we can fix it now.
>
> Also as others have noted, this patch set creates an intermediate
> state where functionality is effectively broken. So it is illogical
> to knowingly merge this patch series as-is. You'll have to piece
> together all of the changes necessary such that the series is fully
> bisectable, which means at every patch along the way things function
> properly and do not break.
Dully noted.
Thank you,
-v
prev parent reply other threads:[~2015-07-09 21:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 21:18 [PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit Vivien Didelot
2015-07-07 21:18 ` [PATCH v4 1/3] net: dsa: mv88e6xxx: add debugfs interface for VTU Vivien Didelot
2015-07-07 21:18 ` [PATCH v4 2/3] net: dsa: add support for switchdev VLAN objects Vivien Didelot
2015-07-07 21:18 ` [PATCH v4 3/3] net: dsa: mv88e6xxx: add switchdev VLAN operations Vivien Didelot
2015-07-08 14:38 ` [PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit Andrew Lunn
2015-07-08 17:13 ` Vivien Didelot
2015-07-08 17:32 ` Andrew Lunn
2015-07-08 18:11 ` Vivien Didelot
2015-07-08 20:08 ` Andrew Lunn
2015-07-08 20:12 ` Andrew Lunn
2015-07-08 20:34 ` Vivien Didelot
2015-07-09 18:01 ` David Miller
2015-07-09 21:03 ` Vivien Didelot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231604948.157146.1436475804451.JavaMail.zimbra@savoirfairelinux.com \
--to=vivien.didelot@savoirfairelinux.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jiri@resnulli.us \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox