From: Harvey Harrison <harvey.harrison@gmail.com>
To: Jaswinder Singh Rajput <jaswinder@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
sam@ravnborg.org, LKML <linux-kernel@vger.kernel.org>,
gorcunov@gmail.com
Subject: Re: [PATCH -tip] coda_psdev.h: extern's make no sense in userspace
Date: Mon, 12 Jan 2009 23:22:03 -0800 [thread overview]
Message-ID: <1231831324.5405.25.camel@brick> (raw)
In-Reply-To: <1231828614.3212.15.camel@jaswinder.satnam>
On Tue, 2009-01-13 at 12:06 +0530, Jaswinder Singh Rajput wrote:
> Impact: fix make headers_check warning:
>
> usr/include/linux/coda_psdev.h:90: extern's make no sense in userspace
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> ---
> include/linux/coda_psdev.h | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/coda_psdev.h b/include/linux/coda_psdev.h
> index 07ae8f8..c620958 100644
> --- a/include/linux/coda_psdev.h
> +++ b/include/linux/coda_psdev.h
> @@ -87,6 +87,8 @@ struct upc_req {
> * Statistics
> */
>
> +#ifdef __KERNEL__
> extern struct venus_comm coda_comms[];
> +#endif /* __KERNEL__ */
As this only gets used in code/inode.c, coda/psdev.c it would be nice if
a code-internal header could be found that could hold this.
This is only here due to the one use outside of psdev.c in inode.c
Harvey
prev parent reply other threads:[~2009-01-13 7:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 6:36 [PATCH -tip] coda_psdev.h: extern's make no sense in userspace Jaswinder Singh Rajput
2009-01-13 7:22 ` Harvey Harrison [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231831324.5405.25.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gorcunov@gmail.com \
--cc=jaswinder@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox