Re: [PATCH 0/10] MAINTAINERS - script, patterns, and misc fixes

Joe Perches
2009-01-14T04:26:15Z

On Tue, 2009-01-13 at 12:54 -0800, Andrew Morton wrote:
> akpm:/usr/src/git26> ../25/scripts/get_maintainer.pl -f mm/filemap.c
> Balbir Singh <balbir@linux.vnet.ibm.com>
> Hugh Dickins <hugh@veritas.com>
> KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> Miklos Szeredi <mszeredi@suse.cz>
> Nick Piggin <npiggin@suse.de>
>
> I think Balbir would be surprised!

get_maintainer output is in alphabetical order,
not ordered by signer frequency.

Balbir Singh is one of the top 5 signers over the last year
for mm/filemap.c excluding you and Linus.

$ git log --since=1-year-ago mm/filemap.c | \
grep -P "^ +.*by:" | sort | uniq -c | sort -rn | head
38 Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
35 Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
14 Signed-off-by: Nick Piggin <npiggin@suse.de>
5 Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
5 Signed-off-by: Hugh Dickins <hugh@veritas.com>
4 Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
4 Signed-off-by: Balbir Singh <balbir@linux.vnet.ibm.com>

> My script generates what I consider to be better results:
>
> akpm:/usr/src/25> who-maintains.sh mm/filemap.c
> Nick Piggin <npiggin@suse.de>
> Hugh Dickins <hugh@veritas.com>
> Fengguang Wu <wfg@mail.ustc.edu.cn>
> Christoph Hellwig <hch@lst.de>
> Steven Whitehouse <swhiteho@redhat.com>
> Zach Brown <zach.brown@oracle.com>
> Miklos Szeredi <mszeredi@suse.cz>
> Jan Kara <jack@suse.cz>
> Balbir Singh <balbir@linux.vnet.ibm.com>
> Badari Pulavarty <pbadari@us.ibm.com>
>
> For some (git related) reason it is vastly slower than yours.

I think the major reason is your script is using all git history.
get_maintainer.pl is using just the last calendar year.