From: Peter Zijlstra <peterz@infradead.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Gregory Haskins <ghaskins@novell.com>,
rostedt@home.goodmis.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] sched: fix build error in kernel/sched_rt.c when RT_GROUP_SCHED && !SMP
Date: Wed, 14 Jan 2009 11:54:36 +0100 [thread overview]
Message-ID: <1231930476.7141.27.camel@twins> (raw)
In-Reply-To: <20090114080111.GC18649@elte.hu>
On Wed, 2009-01-14 at 09:01 +0100, Ingo Molnar wrote:
> * Gregory Haskins <ghaskins@novell.com> wrote:
>
> > +#define dec_rt_group(rt_se, rt_rq) do { } while (0)
>
> Please dont _ever_ introduce new CPP macros into core kernel code, and if
> you see existing once, please fix them to be proper C inline functions.
> (there's a few other new macros in your patchset)
Generally good advice, and certainly doable in this case. But in some
very rare occasions I've had to use CPP in order to avoid silly header
dependency hell -- I think we should add comments in such cases as to
why we use CPP.
next prev parent reply other threads:[~2009-01-14 10:55 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-05 14:24 [git pull] RT scheduler updates for tip Gregory Haskins
2008-12-08 14:32 ` Ingo Molnar
2008-12-08 16:05 ` [PATCH] sched: fix build failure in kernel/sched_rt.c Ingo Molnar
2008-12-08 16:14 ` Gregory Haskins
2008-12-08 16:12 ` [git pull] RT scheduler updates for tip Ingo Molnar
2008-12-08 16:57 ` Gregory Haskins
2008-12-09 14:35 ` Gregory Haskins
2008-12-12 11:34 ` Ingo Molnar
2008-12-12 11:49 ` Ingo Molnar
2008-12-29 15:37 ` Gregory Haskins
2008-12-29 18:13 ` Gregory Haskins
2009-01-11 4:01 ` Ingo Molnar
2009-01-11 9:53 ` Ingo Molnar
2009-01-12 14:45 ` Gregory Haskins
2009-01-12 14:45 ` Ingo Molnar
2009-01-12 15:05 ` Gregory Haskins
2009-01-12 19:23 ` [git pull] fixes for tip/sched/rt Gregory Haskins
2009-01-13 1:43 ` Ingo Molnar
2009-01-13 2:37 ` [PATCH v2] sched: fix build error in kernel/sched_rt.c when RT_GROUP_SCHED && !SMP Gregory Haskins
2009-01-14 8:01 ` Ingo Molnar
2009-01-14 10:54 ` Peter Zijlstra [this message]
2009-01-14 11:03 ` Ingo Molnar
2009-01-14 13:21 ` Gregory Haskins
2009-01-14 14:46 ` [PATCH v3 0/2] fixes for tip/sched/rt Gregory Haskins
2009-01-14 14:46 ` [PATCH v3 1/2] sched: de CPP-ify the scheduler code Gregory Haskins
2009-01-14 15:11 ` Steven Rostedt
2009-01-14 15:28 ` Gregory Haskins
2009-01-14 14:46 ` [PATCH v3 2/2] sched: fix build error in kernel/sched_rt.c when RT_GROUP_SCHED && !SMP Gregory Haskins
2009-01-15 12:30 ` [PATCH v3 0/2] fixes for tip/sched/rt Ingo Molnar
2009-01-16 13:35 ` Ingo Molnar
2009-01-16 13:45 ` Gregory Haskins
2009-01-16 13:46 ` Peter Zijlstra
2009-01-16 14:02 ` Gregory Haskins
2009-01-16 14:02 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231930476.7141.27.camel@twins \
--to=peterz@infradead.org \
--cc=ghaskins@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@home.goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox