From: Harvey Harrison <harvey.harrison@gmail.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>,
Jaswinder Singh Rajput <jaswinder@infradead.org>,
Ingo Molnar <mingo@elte.hu>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
gorcunov@gmail.com, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -tip] nubus.h: extern's make no sense in userspace
Date: Wed, 14 Jan 2009 12:13:19 -0800 [thread overview]
Message-ID: <1231963999.5756.11.camel@brick> (raw)
In-Reply-To: <20090114201019.GB1556@uranus.ravnborg.org>
On Wed, 2009-01-14 at 21:10 +0100, Sam Ravnborg wrote:
> On Wed, Jan 14, 2009 at 12:04:21PM -0800, Harvey Harrison wrote:
> >
> > I had a look at this file, there's the small patch that just wraps the whole
> > section of function declarations with ifdef __KERNEL, or the larger patch
> > that does the wrapping _and_ adds the missing externs to make it obvious.
> >
> > But I'm not sure that there is agreement regarding adding the externs too.
> >
> > What do people think?
>
> The general consensus is to add externs for new prototypes.
> So if _and only if_ you are anyway touching this file in that area then
> I would say - add the externs. But just adding externs are not (yet)
> worth a patch alone.
>
Agreed about just adding externs not being worth it, but as part of auditing
this file for userspace inclusion I'll send the patch that adds the externs
as well as the ifdef __KERNEL__ bits.
Harvey
prev parent reply other threads:[~2009-01-14 20:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 7:48 [PATCH -tip] nubus.h: extern's make no sense in userspace Jaswinder Singh Rajput
2009-01-13 9:03 ` Geert Uytterhoeven
2009-01-14 20:04 ` Harvey Harrison
2009-01-14 20:10 ` Sam Ravnborg
2009-01-14 20:13 ` Harvey Harrison [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231963999.5756.11.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gorcunov@gmail.com \
--cc=jaswinder@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox