public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tim Blechmann <tim@klingt.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Andi Kleen <ak@linux.intel.com>,
	oprofile-list@lists.sf.net, linux-kernel@vger.kernel.org,
	Robert Richter <robert.richter@amd.com>,
	venkatesh.pallipadi@intel.com
Subject: Re: 2.6.28-rc9: oprofile regression
Date: Fri, 16 Jan 2009 01:53:01 +0100	[thread overview]
Message-ID: <1232067181.6134.74.camel@thinkpad> (raw)
In-Reply-To: <alpine.LFD.2.00.0901152135110.3400@localhost.localdomain>

[-- Attachment #1: Type: text/plain, Size: 1684 bytes --]

On Thu, 2009-01-15 at 21:37 +0100, Thomas Gleixner wrote:
> On Thu, 15 Jan 2009, Tim Blechmann wrote:
> > On Thu, 2009-01-15 at 09:46 +0100, Thomas Gleixner wrote:
> > > Tim,
> > > 
> > > On Wed, 14 Jan 2009, Tim Blechmann wrote:
> > > > this code (line 81/82), changes counter_width from 32 to 40.
> > > > 
> > > > if (counter_width < eax.split.bit_width)
> > > >         counter_width = eax.split.bit_width;
> > > > 
> > > > however when removing these lines, and thus keeping the value 32 for
> > > > counter_width, doesn't change the behavior, only one NMI per cpu.
> > > 
> > > It would only help, when the reported bit_width would be bogus. We
> > > know that you get at least one NMI, so lets look at the results we get
> > > there.
> > 
> > it seems, that ppro_check_ctrs is never called:
> > [  982.238639] oprofile: using NMI interrupt.
> > 
> > hth, tim
> 
> Hmm, that confuses the hell out of me. Can you try the patch below,
> which restores the original code of writing the counter registers ?

no difference ... i must admit, i already spent some time, trying to
revert the specific changes of this commit ... i gave up to wait for
some help from someone, who actually knows how the code is working ...

possibly it makes sense to compile a full kernel of the first bad kommit
and introduce the different changes one by one ... i will try to find
some time for this during the next few days ...

but if you have more patches, that i can test, please let me know ...

cheers, tim
 
--
tim@klingt.org
http://tim.klingt.org

Which is more musical, a truck passing by a factory or a truck passing
by a music school?
  John Cage

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

  reply	other threads:[~2009-01-16  0:53 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-21 14:23 2.6.28-rc9: oprofile regression Tim Blechmann
2008-12-21 21:23 ` Tim Blechmann
2008-12-22 12:11   ` Robert Richter
2008-12-26  2:42   ` Andi Kleen
2009-01-02 11:04     ` Tim Blechmann
2009-01-14 17:10       ` Thomas Gleixner
2009-01-14 18:19         ` Tim Blechmann
2009-01-15  8:46           ` Thomas Gleixner
2009-01-15  9:14             ` Tim Blechmann
2009-01-15 20:37               ` Thomas Gleixner
2009-01-16  0:53                 ` Tim Blechmann [this message]
2009-01-16  8:59                   ` Thomas Gleixner
2009-01-16 11:29                     ` Tim Blechmann
2009-01-16 15:52                       ` Thomas Gleixner
2009-01-16 16:02                         ` Tim Blechmann
2009-01-17 13:32                     ` Tim Blechmann
2009-01-17 14:14                       ` Robert Richter
2009-01-17 15:09                         ` Tim Blechmann
2009-01-17 15:56                           ` Robert Richter
2009-01-17 16:40                             ` Tim Blechmann
2009-02-11 19:51 ` 2.6.29-rc4 regression (was: Re: 2.6.28-rc9: oprofile regression) Tim Blechmann
2009-02-13 19:07   ` Robert Richter
2009-02-16 10:23     ` Tim Blechmann
2009-02-16 11:33       ` Robert Richter
2009-02-16 12:53         ` 2.6.29-rc4 regression Tim Blechmann
2009-02-17  7:45           ` Mike Galbraith
2009-02-17 21:56             ` Tim Blechmann
2009-02-18  4:54               ` Mike Galbraith
2009-02-16 11:40       ` 2.6.29-rc4 regression (was: Re: 2.6.28-rc9: oprofile regression) Robert Richter
2009-02-19 16:34         ` [PATCH] oprofile: don't set counter width from cpuid on core2 Tim Blechmann
2009-03-03 10:04           ` Robert Richter
2009-03-03 11:05             ` Ingo Molnar
2009-03-03 11:09             ` [tip:x86/urgent] x86: oprofile: don't set counter width from cpuid on Core2 Tim Blechmann
  -- strict thread matches above, loose matches on Subject: below --
2008-12-22 14:55 2.6.28-rc9: oprofile regression Tim Blechmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1232067181.6134.74.camel@thinkpad \
    --to=tim@klingt.org \
    --cc=ak@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oprofile-list@lists.sf.net \
    --cc=robert.richter@amd.com \
    --cc=tglx@linutronix.de \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox