Re: [git pull] scheduler fixes

Toralf Förster
2008-07-01T20:36:56Z

[-- Attachment #1: Type: text/plain, Size: 702 bytes --]

Hello,

I've one question related to that patch:

At Tue Jul 1 22:35:30 CEST 2008 Ingo Molnar wrote :
>diff --git a/kernel/sched.c b/kernel/sched.c
>index a66e856..94ead43 100644
>--- a/kernel/sched.c
>+++ b/kernel/sched.c
>@@ -8502,6 +8502,9 @@ int sched_group_set_rt_period(struct task_group *tg, long rt_period_us)
> rt_period = (u64)rt_period_us * NSEC_PER_USEC;
> rt_runtime = tg->rt_bandwidth.rt_runtime;
>
>+ if (rt_period == 0)
>+ return -EINVAL;
>+
> return tg_set_bandwidth(tg, rt_period, rt_runtime);

Why isn't the check be make before rt_runtime is set ?

--
MfG/Sincerely

Toralf Förster
pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]