Re: [git pull] scheduler fixes

Adrian Bunk
2008-05-08T19:43:56Z

On Thu, May 08, 2008 at 05:41:16PM +0200, Ingo Molnar wrote:
>
> * Adrian Bunk <bunk@kernel.org> wrote:
>
> > Can we get that verified and the description updated before it hits
> > Linus' tree?
>
> that's not needed. Mike's fix is correct, regardless of whether it fixes
> the other regression or not.

Then scrap the part about it possibly fixing a regression and the
Reported-by: line.

> > Otherwise this "could be related" will become unchangable metadata
> > that will stay forever - no matter whether there's any relation at
> > all.
>
> ... and the problem with that is exactly what?

It is important that our metadata is as complete and correct as
reasonably possible. Our code is not as well documented as it should be,
and in my experience often the only way to understand what happens and
why it happens is to ask git for the metadata (and I'm actually doing
this even for most of my "trivial" patches).

In 3 hours or 3 years someone might look at this commit trying to
understand what it does and why it does this.

And there's a big difference between "we do it because it's correct from
a theoretical point of view" and "it is supposed to fix a huge
performance regression".

> Ingo

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed