From: Chris Mason <chris.mason@oracle.com>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: linux-btrfs@vger.kernel.org, bug-glibc@gnu.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: btrfs: readdir problem workaround for 32-bit off_t
Date: Sat, 17 Jan 2009 16:27:21 -0500 [thread overview]
Message-ID: <1232227641.28343.3.camel@think.oraclecorp.com> (raw)
In-Reply-To: <alpine.LSU.2.00.0901172026180.14987@fbirervta.pbzchgretzou.qr>
On Sat, 2009-01-17 at 20:39 +0100, Jan Engelhardt wrote:
> Hi,
>
>
>
> I am seeing abnormal kernel<->userland interaction for range-exceeding
> offsets during readdir.
> A suggested patch for btrfs is below, but I think there could also
> be involvement of (read: a bug in) Glibc.
> Would the copied parties please have a look, as it may spans both glibc
> and btrfs.
>
Thanks for looking into this.
Your patch is how the code originally looked, but it can lead to loops
in buggy userland (a git bug hit this). My plan was to mask off the
limit the same way XFS now does.
This is a btrfs bug, not glibc.
-chris
prev parent reply other threads:[~2009-01-17 21:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-17 19:39 btrfs: readdir problem workaround for 32-bit off_t Jan Engelhardt
2009-01-17 21:27 ` Chris Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232227641.28343.3.camel@think.oraclecorp.com \
--to=chris.mason@oracle.com \
--cc=bug-glibc@gnu.org \
--cc=jengelh@medozas.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox