From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932523AbdCTSz1 (ORCPT ); Mon, 20 Mar 2017 14:55:27 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:33222 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755878AbdCTSzS (ORCPT ); Mon, 20 Mar 2017 14:55:18 -0400 X-AuditID: b6c32a37-f796f6d000001a35-91-58d02557bc58 From: Bartlomiej Zolnierkiewicz To: Dmitry Torokhov Cc: Antonino Daplas , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] video: fbdev: i810: remove incorrect __exit markups Date: Mon, 20 Mar 2017 19:54:12 +0100 Message-id: <12322916.Av75cuhlH6@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170320184256.GB23083@dtor-ws> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCIsWRmVeSWpSXmKPExsWy7bCmgW646oUIg8k/lS1+dn9hszi86AWj xYm+D6wWl3fNYXNg8dg56y67x+dNcgFMUVw2Kak5mWWpRfp2CVwZe5s/MBdMFq3Ys+wNYwPj GcEuRk4OCQETiZa1h5khbDGJC/fWs3UxcnEICexglFiwYTEzhNPOJNH4tJ8VpuPwzLXsEIk5 jBI3rhyEqvrKKLFj/nw2kCo2ASuJie2rGEFsEQF9ie2zf4HZzAIpEpMezAfbJyzgIfFmzlZ2 EJtFQFXiwLUjYL28AloSnzZ+BLNFBbwktuxrZwKxOQV0JQ58WMQCUSMo8WPyPRaImfIS+/ZP ZYWwdSTOHlvHCHKQhMB3Nonlv/YBDeIAcmQlNh2A+tNFYuK7L1DfCEu8Or6FHcKWllj17xYT hD2dUWL7bwmIOZsZJVbtngBVZC1x+PhFqGV8Eu++9rBCzOeV6GgTgijxkFh3eBc7RNhRYv5v HZCwkMA8RoltC6wnMMrPQvLBLCQfzELywQJG5lWMYqkFxbnpqcWGBcZ6xYm5xaV56XrJ+bmb GMFpQct8B+OGcz6HGAU4GJV4eFdcOR8hxJpYVlyZe4hRgoNZSYT3o+KFCCHelMTKqtSi/Pii 0pzU4kOM0hwsSuK8rAYTI4QE0hNLUrNTUwtSi2CyTBycUg2MAeeff7Txtn/wKLb3dsISnzvO lfMPJZlNVDtu6/78a5pH7+7m2DOsD/dM/blI9NzPV8Z/PgYoGWrYaP7tqS9hvffy/J0ag9hU hysrfTZ8udznkFbt3HPos2D/4eefDNT3OjFPNZ9VPG3HWeMvhmn8DFf3u2o9d0vb+W7K9Wf/ Xut9/3J056y+HUosxRmJhlrMRcWJADZZsLEHAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBIsWRmVeSWpSXmKPExsVy+t9jQd1w1QsRBs+nCVj87P7CZnF40QtG ixN9H1gtLu+aw+bA4rFz1l12j8+b5AKYotxsMlITU1KLFFLzkvNTMvPSbZVCQ9x0LZQU8hJz U22VInR9Q4KUFMoSc0qBPCMDNODgHOAerKRvl+CWsbf5A3PBZNGKPcveMDYwnhHsYuTkkBAw kTg8cy07hC0mceHeerYuRi4OIYFZjBJP1kxlgXC+Mko8e7+GCaSKTcBKYmL7KkYQW0RAX2L7 7F9gNrNAisS9rUtYQWxhAQ+JN3O2gk1lEVCVOHDtCBuIzSugJfFp40cwW1TAS2LLvnawmZwC uhIHPiyCWraAUaJ7z0qoBkGJH5PvsUAskJfYt38qK4StJbF+53GmCYxAdyKUzUJSNgtJ2QJG 5lWMEqkFyQXFSem5hnmp5XrFibnFpXnpesn5uZsYwbHyTGoH48Fd7ocYBTgYlXh4V1w5HyHE mlhWXJl7iFGCg1lJhPej4oUIId6UxMqq1KL8+KLSnNTiQ4ymQB9OZJYSTc4HxnFeSbyhibmJ ubGBhbmlpYmRkjhv4+xn4UIC6YklqdmpqQWpRTB9TBycUg2MO2erlyopC/nKB7dNm+J9eYLD K4/U9GCnkGbXM9f+T+IveXwsV3Gln8KsWR9T/Q9s1X4UZP5+B2faT93prq3s6xim5C4NWB8a bfSj+tNH9ZpJsUzSi+z56wz5tCMYrlW1FqWp9a6Qk4412xZ/8/2qMJUDLAFdV0TnZj2dt22T A+tpm77ZSs1KLMUZiYZazEXFiQCd4B0UqwIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170320185415epcas1p2b50db3c413d50eba3c421951a32fe049 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-HopCount: 7 X-CMS-RootMailID: 20170302013109epcas3p3ae90f60d7aa8f14bb09eb5ec342cfaeb X-RootMTR: 20170302013109epcas3p3ae90f60d7aa8f14bb09eb5ec342cfaeb References: <1880466.B5ZPIScV32@amdc3058> <20170320184256.GB23083@dtor-ws> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, March 20, 2017 11:42:56 AM Dmitry Torokhov wrote: > Hi Bartlomiej, > > On Mon, Mar 20, 2017 at 06:19:17PM +0100, Bartlomiej Zolnierkiewicz wrote: > > On Wednesday, March 01, 2017 05:31:01 PM Dmitry Torokhov wrote: > > > Even if bus is not hot-pluggable, devices can be unbound from the > > > driver via sysfs, so we should not be using __exit annotations on > > > remove() methods. The only exception is drivers registered with > > > platform_driver_probe() which specifically disables sysfs bind/unbind > > > attributes. > > > > > > Signed-off-by: Dmitry Torokhov > > > > Patch queued for 4.12, thanks. > > > > It seems that there are still some fbdev drivers with this issue: > > I do not think so: > > > > > $ git grep __exit_p drivers/video/fbdev/ > > drivers/video/fbdev/amifb.c: .remove = __exit_p(amifb_remove), > > Registered as module_platform_driver_probe(), which ends up suppressing > sysfs bind/unbind attributes. > > > drivers/video/fbdev/atmel_lcdfb.c: .remove = __exit_p(atmel_lcdfb_remove), > > Registered as module_platform_driver_probe(), which ends up suppressing > sysfs bind/unbind attributes. > > > drivers/video/fbdev/omap2/omapfb/displays/connector-analog-tv.c: .remove = __exit_p(tvc_remove), > > drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c: .remove = __exit_p(dvic_remove), > > drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c: .remove = __exit_p(hdmic_remove), > > drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c: .remove = __exit_p(opa362_remove), > > drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410.c: .remove = __exit_p(tfp410_remove), > > drivers/video/fbdev/omap2/omapfb/displays/encoder-tpd12s015.c: .remove = __exit_p(tpd_remove), > > drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c: .remove = __exit_p(panel_dpi_remove), > > drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c: .remove = __exit_p(dsicm_remove), > > drivers/video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01.c: .remove = __exit_p(sharp_ls_remove), > > As far as I can see all omapfb/displays/ drivers explicitly disable > bind/unbind attributes by setting: > > .suppress_bind_attrs = true, > > > > drivers/video/fbdev/omap2/omapfb/vrfb.c: .remove = __exit_p(vrfb_remove), > > Registered as module_platform_driver_probe(), which ends up suppressing > sysfs bind/unbind attributes. You're right of course, thanks for explaining this and auditing all fbdev drivers. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics