From: Harvey Harrison <harvey.harrison@gmail.com>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Sam Ravnborg <sam@ravnborg.org>, x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL -tip v3] fix 39 'make headers_check' warnings
Date: Sun, 18 Jan 2009 18:20:46 -0800 [thread overview]
Message-ID: <1232331646.5570.5.camel@brick> (raw)
In-Reply-To: <1232331011.3129.4.camel@localhost.localdomain>
On Mon, 2009-01-19 at 07:40 +0530, Jaswinder Singh Rajput wrote:
> On Sun, 2009-01-18 at 19:50 +0100, Ingo Molnar wrote:
> >
> > why does such a change introduce new code? It is duplicating existing code
> > instead of cleaning it all up.
> >
>
> That's why I was requesting you to check asm/swab.h because I was in
> doubt whether we need these functions in userspace or not.
>
> If we do not need these functions in userspace then I will clean these
> up.
>
As part of doing the swab.h splitout it was very tempting to just stop
exporting _all_ of the asm/swab.h files now that there is a linux/swab.h.
But I ended up leaving things as they were on arches that did expose
their arch specific versions to userspace.
Just a thought.
Harvey
next prev parent reply other threads:[~2009-01-19 2:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-18 14:04 [GIT PULL -tip v3] fix 39 'make headers_check' warnings Jaswinder Singh Rajput
2009-01-18 17:28 ` Ingo Molnar
2009-01-18 18:50 ` Ingo Molnar
2009-01-18 18:52 ` Ingo Molnar
2009-01-18 19:08 ` Sam Ravnborg
2009-01-18 19:09 ` Ingo Molnar
2009-01-18 19:45 ` Sam Ravnborg
2009-01-19 2:16 ` Jaswinder Singh Rajput
2009-01-19 5:27 ` Sam Ravnborg
2009-01-19 2:10 ` Jaswinder Singh Rajput
2009-01-19 2:20 ` Harvey Harrison [this message]
2009-01-19 11:15 ` Ingo Molnar
2009-01-19 18:08 ` Harvey Harrison
2009-01-18 18:56 ` Ingo Molnar
2009-01-19 9:19 ` Avi Kivity
2009-01-19 11:01 ` Sam Ravnborg
2009-01-19 11:53 ` Avi Kivity
2009-01-24 6:16 ` Jaswinder Singh Rajput
2009-02-04 14:28 ` Avi Kivity
2009-02-04 15:17 ` Jaswinder Singh Rajput
2009-02-04 15:40 ` Avi Kivity
2009-02-04 16:00 ` Jaswinder Singh Rajput
2009-02-04 16:37 ` Arnd Bergmann
2009-02-04 17:22 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232331646.5570.5.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jaswinder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox