Re: [GIT PULL -tip v3] fix 39 'make headers_check' warnings

Jaswinder Singh Rajput
2009-01-19T02:17:24Z

On Sun, 2009-01-18 at 20:08 +0100, Sam Ravnborg wrote:
> >
> > diff --git a/arch/x86/include/asm/swab.h b/arch/x86/include/asm/swab.h
> > index 306d417..613be68 100644
> > --- a/arch/x86/include/asm/swab.h
> > +++ b/arch/x86/include/asm/swab.h
> > @@ -1,12 +1,15 @@
> > #ifndef _ASM_X86_SWAB_H
> > #define _ASM_X86_SWAB_H
> >
> > -#include <asm/types.h>
> > +#include <linux/types.h>
> > +#ifdef __KERNEL__
> > #include <linux/compiler.h>
> > +#endif /* __KERNEL__ */
>
> compiler.h includes should be nuked by make headers_instll automatically.
>

But the problem is compiler.h provide extra line space in userspace
header files because of nuking them.

So I moved compiler.h in __KERNEL__ as extra cleanup, it is not harmful
but looks much nicer in userspace header files

--
JSR