Re: [GIT PULL -tip v3] fix 39 'make headers_check' warnings

Harvey Harrison
2009-01-19T02:21:01Z

On Mon, 2009-01-19 at 07:40 +0530, Jaswinder Singh Rajput wrote:
> On Sun, 2009-01-18 at 19:50 +0100, Ingo Molnar wrote:
> >
> > why does such a change introduce new code? It is duplicating existing code
> > instead of cleaning it all up.
> >
>
> That's why I was requesting you to check asm/swab.h because I was in
> doubt whether we need these functions in userspace or not.
>
> If we do not need these functions in userspace then I will clean these
> up.
>

As part of doing the swab.h splitout it was very tempting to just stop
exporting _all_ of the asm/swab.h files now that there is a linux/swab.h.
But I ended up leaving things as they were on arches that did expose
their arch specific versions to userspace.

Just a thought.

Harvey