Re: [RFC] per-CPU cryptd thread implementation based on workqueue

[Huang Ying <ying.huang@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 934 bytes --]

On Thu, 2009-01-22 at 11:04 +0800, Herbert Xu wrote:
> On Thu, Jan 22, 2009 at 10:32:17AM +0800, Huang Ying wrote:
> >
> > This is the first attempt to use a dedicate workqueue for crypto. It is
> > not intended to be merged. Please feedback your comments, especially on
> > desgin.
> 
> Thanks for the patch!
> 
> > +		spin_lock_init(&cpu_queue->lock);
> 
> Since we're switching to per-cpu queues it would be good to just
> kill the spin lock.  AFAICS the only place you really need it is
> in cryptd_tfm_in_queue.  That's just used for debugging so we can
> just kill it and lose this spin lock.

Yes. Except that, now we do not need a spin lock really. I think the
spin lock may be useful if we enqueue a request on other CPU's queue to
do load balance. And if it is possible that the work_struct to be
executed on CPU other original CPU for CPU hotplug (current code do
not).

Best Regards,
Huang Ying
 

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]