From: Brian Gerst <brgerst@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Tejun Heo <tj@kernel.org>, linux-kernel@vger.kernel.org
Subject: [PATCH 06/12] x86: Only compile setup_percpu.o on SMP
Date: Mon, 26 Jan 2009 01:15:26 -0500 [thread overview]
Message-ID: <1232950532-22923-6-git-send-email-brgerst@gmail.com> (raw)
In-Reply-To: <73c1f2160901252214k394d198dn815670e7f667b3ac@mail.gmail.com>
Impact: Minor build optimization
Signed-off-by: Brian Gerst <brgerst@gmail.com>
---
arch/x86/kernel/Makefile | 3 ++-
arch/x86/kernel/setup_percpu.c | 6 ------
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile
index a99437c..73de055 100644
--- a/arch/x86/kernel/Makefile
+++ b/arch/x86/kernel/Makefile
@@ -28,7 +28,7 @@ CFLAGS_paravirt.o := $(nostackp)
obj-y := process_$(BITS).o signal.o entry_$(BITS).o
obj-y += traps.o irq.o irq_$(BITS).o dumpstack_$(BITS).o
obj-y += time_$(BITS).o ioport.o ldt.o dumpstack.o
-obj-y += setup.o i8259.o irqinit_$(BITS).o setup_percpu.o
+obj-y += setup.o i8259.o irqinit_$(BITS).o
obj-$(CONFIG_X86_VISWS) += visws_quirks.o
obj-$(CONFIG_X86_32) += probe_roms_32.o
obj-$(CONFIG_X86_32) += sys_i386_32.o i386_ksyms_32.o
@@ -59,6 +59,7 @@ apm-y := apm_32.o
obj-$(CONFIG_APM) += apm.o
obj-$(CONFIG_X86_SMP) += smp.o
obj-$(CONFIG_X86_SMP) += smpboot.o tsc_sync.o ipi.o
+obj-$(CONFIG_SMP) += setup_percpu.o
obj-$(CONFIG_X86_32_SMP) += smpcommon.o
obj-$(CONFIG_X86_64_SMP) += tsc_sync.o smpcommon.o
obj-$(CONFIG_X86_TRAMPOLINE) += trampoline_$(BITS).o
diff --git a/arch/x86/kernel/setup_percpu.c b/arch/x86/kernel/setup_percpu.c
index d367996..f30ff69 100644
--- a/arch/x86/kernel/setup_percpu.c
+++ b/arch/x86/kernel/setup_percpu.c
@@ -22,14 +22,8 @@
# define DBG(x...)
#endif
-/*
- * Could be inside CONFIG_HAVE_SETUP_PER_CPU_AREA with other stuff but
- * voyager wants cpu_number too.
- */
-#ifdef CONFIG_SMP
DEFINE_PER_CPU(int, cpu_number);
EXPORT_PER_CPU_SYMBOL(cpu_number);
-#endif
#ifdef CONFIG_HAVE_SETUP_PER_CPU_AREA
--
1.6.1
next prev parent reply other threads:[~2009-01-26 6:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-26 6:14 [PATCH 0/12] Next batch of x86 percpu changes Brian Gerst
2009-01-26 6:15 ` [PATCH 01/12] x86: Merge setup_per_cpu_maps() into setup_per_cpu_areas() Brian Gerst
2009-01-26 6:15 ` [PATCH 02/12] x86: Move 64-bit NUMA code Brian Gerst
2009-01-26 6:15 ` [PATCH 03/12] x86: Move setup_cpu_local_masks() Brian Gerst
2009-01-26 6:15 ` [PATCH 04/12] x86: Always page-align per-cpu area start and size Brian Gerst
2009-01-26 6:15 ` [PATCH 05/12] x86: Move apic variables to apic.c Brian Gerst
2009-01-26 6:15 ` Brian Gerst [this message]
2009-01-26 6:15 ` [PATCH 07/12] x86: Move this_cpu_offset Brian Gerst
2009-01-26 6:15 ` [PATCH 08/12] x86: Don't assume boot cpu is #0 Brian Gerst
2009-01-26 6:15 ` [PATCH 09/12] x86: Make Voyager use x86 per-cpu setup Brian Gerst
2009-01-26 6:15 ` [PATCH 10/12] x86: Initialize per-cpu GDT segment in " Brian Gerst
2009-01-26 6:15 ` [PATCH 11/12] x86: Remove extra barriers from load_gs_base() Brian Gerst
2009-01-26 6:15 ` [PATCH 12/12] x86: Load new GDT after setting up boot cpu per-cpu area Brian Gerst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232950532-22923-6-git-send-email-brgerst@gmail.com \
--to=brgerst@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox