From: Peter Zijlstra <peterz@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jens Axboe <jens.axboe@oracle.com>,
Steven Rostedt <rostedt@goodmis.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Rusty Russell <rusty@rustcorp.com.au>,
npiggin@suse.de, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH -v3] use per cpu data for single cpu ipi calls
Date: Fri, 30 Jan 2009 17:16:10 +0100 [thread overview]
Message-ID: <1233332170.4495.200.camel@laptop> (raw)
In-Reply-To: <alpine.LFD.2.00.0901300800350.3150@localhost.localdomain>
On Fri, 2009-01-30 at 08:04 -0800, Linus Torvalds wrote:
> My only question is whetherr we might even drop the kmalloc() some day:
> I suspect that the CSD_FLAG_LOCK is essentially never a contention point,
> and the cost (and occasional synchronization) of kmalloc() quite possibly
> overwhelms any theoretical scaling ability.
IIRC the recent SL*B numbers posted showed that a kmalloc could be as
cheap as ~100 cycles or something. IPIs are sadly still a bit more
expensive.
> If another CPU hasn't even received its IPI before the same CPU sends the
> next one, I'm not sure we _want_ to send one, in fact.
I think the intent was to re-route IO-completion interrupts to whatever
cpu/node issued the IO with the idea that that cpu/node has the page
hottest etc. and transferring the completion is cheaper than bouncing
the page.
Since that would be relaying hardware interrupts, there's nothing much
you can do about the rate, or something, that's up to the firmware on
$$$ scsi thing.
But Jens already said that that path was using the __ variant and
providing its own csds, the kmalloc isn't needed there, so it might all
be moot.
> But that's a secondary issue, and isn't a correctness thing, just a "do we
> really need three different allocations?" musing..
Nick, Jens, I was under the presumption that the kmalloc was needed for
something other than failing to deadlock, happen to remember what?
next prev parent reply other threads:[~2009-01-30 16:16 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-28 16:38 Buggy IPI and MTRR code on low memory Steven Rostedt
2009-01-28 16:41 ` Steven Rostedt
2009-01-28 16:46 ` Peter Zijlstra
2009-01-28 16:56 ` Steven Rostedt
2009-01-28 17:00 ` Peter Zijlstra
2009-01-28 17:24 ` Steven Rostedt
2009-01-28 18:20 ` Peter Zijlstra
2009-01-28 18:52 ` Steven Rostedt
2009-01-28 18:22 ` Arjan van de Ven
2009-01-28 18:34 ` Steven Rostedt
2009-01-28 21:12 ` Andrew Morton
2009-01-28 21:13 ` Andrew Morton
2009-01-28 21:23 ` Steven Rostedt
2009-01-28 22:07 ` Andrew Morton
2009-01-28 22:47 ` Steven Rostedt
2009-01-28 23:20 ` Andrew Morton
2009-01-28 23:50 ` Steven Rostedt
2009-01-28 23:25 ` Rusty Russell
2009-01-28 23:41 ` Steven Rostedt
2009-01-29 0:52 ` [PATCH] use per cpu data for single cpu ipi calls Steven Rostedt
2009-01-29 1:30 ` Andrew Morton
2009-01-29 1:56 ` Steven Rostedt
2009-01-29 8:49 ` Peter Zijlstra
2009-01-29 11:13 ` Ingo Molnar
2009-01-29 11:41 ` Peter Zijlstra
2009-01-29 13:42 ` Ingo Molnar
2009-01-29 14:07 ` Steven Rostedt
2009-01-29 15:08 ` [PATCH -v2] " Steven Rostedt
2009-01-29 15:33 ` Peter Zijlstra
2009-01-29 16:17 ` Ingo Molnar
2009-01-29 17:21 ` Linus Torvalds
2009-01-29 17:44 ` Steven Rostedt
2009-01-29 17:50 ` Steven Rostedt
2009-01-29 18:08 ` Linus Torvalds
2009-01-29 18:11 ` Steven Rostedt
2009-01-29 18:23 ` Peter Zijlstra
2009-01-29 18:31 ` Steven Rostedt
2009-01-29 18:39 ` Linus Torvalds
2009-01-29 18:44 ` Peter Zijlstra
2009-01-30 11:23 ` Jens Axboe
2009-01-30 12:32 ` [PATCH -v3] " Peter Zijlstra
2009-01-30 12:38 ` Jens Axboe
2009-01-30 12:48 ` Peter Zijlstra
2009-01-30 12:55 ` Jens Axboe
2009-01-30 12:56 ` Jens Axboe
2009-01-30 13:00 ` Peter Zijlstra
2009-01-30 13:02 ` [PATCH -v4] " Peter Zijlstra
2009-01-30 14:51 ` Ingo Molnar
2009-01-30 16:04 ` [PATCH -v3] " Linus Torvalds
2009-01-30 16:16 ` Peter Zijlstra [this message]
2009-01-31 8:44 ` Jens Axboe
2009-01-29 18:49 ` [PATCH -v2] " Ingo Molnar
2009-01-30 1:55 ` Rusty Russell
2009-01-29 17:47 ` Peter Zijlstra
2009-01-29 17:55 ` Peter Zijlstra
2009-01-29 18:08 ` Steven Rostedt
2009-01-30 1:11 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233332170.4495.200.camel@laptop \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=npiggin@suse.de \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox