From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754983AbZBDEFQ (ORCPT ); Tue, 3 Feb 2009 23:05:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752542AbZBDEFE (ORCPT ); Tue, 3 Feb 2009 23:05:04 -0500 Received: from hera.kernel.org ([140.211.167.34]:45781 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752524AbZBDEFC (ORCPT ); Tue, 3 Feb 2009 23:05:02 -0500 Subject: Re: usr/include/linux/soundcard.h warnings for 'make headers_check' From: Jaswinder Singh Rajput To: Arnd Bergmann Cc: Sam Ravnborg , Takashi Iwai , alsa-devel@alsa-project.org, Ingo Molnar , LKML In-Reply-To: <200902032127.24526.arnd@arndb.de> References: <1232465902.3088.31.camel@localhost.localdomain> <20090121054138.GA26551@uranus.ravnborg.org> <200902032127.24526.arnd@arndb.de> Content-Type: text/plain Date: Wed, 04 Feb 2009 09:34:12 +0530 Message-Id: <1233720252.3595.5.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 (2.24.3-1.fc10) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2009-02-03 at 21:27 +0100, Arnd Bergmann wrote: > On Wednesday 21 January 2009, Sam Ravnborg wrote: > > > > > No, these are declarations for OSS-lib. > > > It doesn't belong to kernel, but it's better to keep it for > > > compatibility in some way. > > > > But not in the kernel for sure. > > I just checked and for example: OSS_init is not used anywhere in the kernel. > > The kernel headers are not a "dump all your stuff" ground anymore. > > > > So I encourage you to find a better home for the user space library definitons. > > We can let the definiton stay for a while - but eventually they have to > > be dropped from the kernel. > > The last free version of OSSlib that matches this header is from ~1997, and > no current distro appears to be shipping it. All new OSSlib versions (the > oldest I found was from ~2003) contain in their documentation: > > "Older versions of some OSS include files are distributed > with various operating systems. There is no danger in > using them but applications written for more recent OSS > versions will not compile with older header files. > > The latest versions of these include files (such as > soundcard.h) are distributed in ../include/sys. Use > the -I/usr/lib/oss/include switch when compiling > programs. Alternatively copy these files to /usr/include/sys > so that they replace the original ones." > > I think it's safe enough to assume that everyone that builds against > OSSlib by now also has the correct version of the header installed. > Consequently, we should just drop the #ifndef __KERNEL__ section > of soundcard.h (all the macros in there depend on the extern > declarations), and maybe add an > > #ifdef OSSLIB > #error need to use from libOSSlib > #endif > sys/soundcard.h is also pointing to linux/soundcard.h, we need to move all this stuff to sys/soundcard.h. Sam also requested to move this stuff to other place. We are waiting for Takashi reply. -- JSR