From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: mingo@elte.hu, x86@kernel.org, sam@ravnborg.org, hpa@zytor.com,
jirislaby@gmail.com, gregkh@suse.de, davem@davemloft.net,
xyzzy@speakeasy.org, arnd@arndb.de, mchehab@infradead.org,
jens.axboe@oracle.com, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org, Avi Kivity <avi@redhat.com>
Subject: Re: [GIT PULL -tip] fix 22 make headers_check - 200901
Date: Wed, 04 Feb 2009 13:34:04 +0530 [thread overview]
Message-ID: <1233734645.3198.2.camel@localhost.localdomain> (raw)
In-Reply-To: <20090204064307.GA18415@gondor.apana.org.au>
On Wed, 2009-02-04 at 17:43 +1100, Herbert Xu wrote:
> Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:
> >
> > diff --git a/arch/x86/include/asm/kvm.h b/arch/x86/include/asm/kvm.h
> > index b95162a..d2e3bf3 100644
> > --- a/arch/x86/include/asm/kvm.h
> > +++ b/arch/x86/include/asm/kvm.h
> > @@ -6,7 +6,7 @@
> > *
> > */
> >
> > -#include <asm/types.h>
> > +#include <linux/types.h>
> > #include <linux/ioctl.h>
>
> Awesome, you've just broken the userspace build of kvm as the
> file linux/types.h conflicts with sys/types.h.
>
What I did is absolutely right.
If there is any conflict then we need to solve it in better way.
Can you please share what is the conflict and what you are expecting and
what you are getting.
Thanks,
--
JSR
next prev parent reply other threads:[~2009-02-04 8:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-24 12:56 [GIT PULL -tip] fix 22 make headers_check - 200901 Jaswinder Singh Rajput
2009-01-24 13:43 ` Jaswinder Singh Rajput
2009-01-26 12:50 ` Ingo Molnar
2009-02-04 6:43 ` Herbert Xu
2009-02-04 8:04 ` Jaswinder Singh Rajput [this message]
2009-02-04 8:12 ` Avi Kivity
2009-02-04 8:13 ` Avi Kivity
2009-02-04 8:37 ` Jaswinder Singh Rajput
2009-02-04 11:55 ` Arnd Bergmann
2009-02-04 14:18 ` Ingo Molnar
2009-02-04 17:33 ` H. Peter Anvin
2009-02-05 14:30 ` Arnd Bergmann
2009-02-05 15:17 ` H. Peter Anvin
2009-02-05 16:07 ` [PATCH] Make exported headers use strict posix types Arnd Bergmann
2009-02-05 17:54 ` H. Peter Anvin
2009-02-05 18:45 ` Arnd Bergmann
2009-02-17 9:38 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233734645.3198.2.camel@localhost.localdomain \
--to=jaswinder@kernel.org \
--cc=arnd@arndb.de \
--cc=avi@redhat.com \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=jens.axboe@oracle.com \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
--cc=x86@kernel.org \
--cc=xyzzy@speakeasy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox