From: Peter Zijlstra <peterz@infradead.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>, Lin Ming <ming.m.lin@intel.com>,
Roland McGrath <roland@redhat.com>,
"Zhang, Yanmin" <yanmin_zhang@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] posix-cpu-timers: use ->sighand instead of ->signal to check the task is alive
Date: Wed, 04 Feb 2009 12:21:19 +0100 [thread overview]
Message-ID: <1233746479.5076.6.camel@laptop> (raw)
In-Reply-To: <20090203231717.GA5028@redhat.com>
On Wed, 2009-02-04 at 00:17 +0100, Oleg Nesterov wrote:
> Sadly, it is not trivial to audit kernel/posix-cpu-timers.c, but it really
> abuses tasklist_lock. I believe it doesn't need this lock at all, but the
> changes are not easy to test.
It uses that to hold of task reaping so ->signal doesn't go away.
If we make ->signal refcountable, and rcu freed along with the tasks I
think we can get away without tasklist_lock.
next prev parent reply other threads:[~2009-02-04 11:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-03 23:17 [PATCH 2/2] posix-cpu-timers: use ->sighand instead of ->signal to check the task is alive Oleg Nesterov
2009-02-04 11:21 ` Peter Zijlstra [this message]
2009-02-04 13:19 ` Oleg Nesterov
2009-02-05 3:31 ` Roland McGrath
2009-02-05 15:54 ` Oleg Nesterov
2009-02-05 20:45 ` Roland McGrath
2009-02-05 22:59 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233746479.5076.6.camel@laptop \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox