From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Frans Pop <elendil@planet.nl>,
rjw@sisk.pl, jbarnes@virtuousgeek.org,
linux-pm@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH 3/7] PCI PM: Fix saving of device state in pci_legacy_suspend
Date: Thu, 05 Feb 2009 11:40:10 +1100 [thread overview]
Message-ID: <1233794410.4612.34.camel@pasglop> (raw)
In-Reply-To: <alpine.LFD.2.00.0902041355320.3247@localhost.localdomain>
On Wed, 2009-02-04 at 13:56 -0800, Linus Torvalds wrote:
>
> On Thu, 5 Feb 2009, Benjamin Herrenschmidt wrote:
> >
> > How so ? I've had such backtraces with no other info in my log...
>
> _with_ that patch?
>
> It very much replaces a warning with no further info with
>
> + WARN_ONCE(pci_dev->current_state != prev,
> + "PCI PM: Device state not saved by %pF\n",
> + drv->suspend);
>
> And notice the "%pF" and the 'drv->suspend': it should tell you exactly
> which suspend routine it was that messed up.
Yup, missed that change in the patch. In fact, I even missed the
existence of a WARN_ONCE that takes those text arguments... baaaah. I
suppose I should try to read more of lkml :-)
Cheers,
Ben.
next prev parent reply other threads:[~2009-02-05 0:41 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-04 0:54 [PATCH 0/7] PCI PM: Fixes and refinements Rafael J. Wysocki
2009-02-04 0:56 ` [PATCH 1/7] PCI PM: Fix handling of devices without drivers Rafael J. Wysocki
2009-02-04 1:53 ` Benjamin Herrenschmidt
2009-02-04 2:23 ` Linus Torvalds
2009-02-04 2:49 ` Benjamin Herrenschmidt
2009-02-04 12:12 ` Rafael J. Wysocki
2009-02-04 12:10 ` Rafael J. Wysocki
2009-02-04 0:57 ` [PATCH 2/7] PCI PM: Check if the state has been saved before trying to restore it Rafael J. Wysocki
2009-02-04 1:54 ` Benjamin Herrenschmidt
2009-02-04 0:59 ` [PATCH 3/7] PCI PM: Fix saving of device state in pci_legacy_suspend Rafael J. Wysocki
2009-02-04 1:56 ` Benjamin Herrenschmidt
2009-02-04 10:14 ` Frans Pop
2009-02-04 21:38 ` Benjamin Herrenschmidt
2009-02-04 21:53 ` Frans Pop
2009-02-04 21:56 ` Linus Torvalds
2009-02-05 0:40 ` Benjamin Herrenschmidt [this message]
2009-02-05 0:57 ` Michael Ellerman
2009-02-05 1:29 ` Benjamin Herrenschmidt
2009-02-05 2:58 ` Michael Ellerman
2009-02-05 4:06 ` Benjamin Herrenschmidt
2009-02-04 1:00 ` [PATCH 4/7] PCI PCIe portdrv: Simplify suspend and resume Rafael J. Wysocki
2009-02-04 1:01 ` [PATCH 5/7] PCI PM: Do not disable and enable bridges during suspend-resume Rafael J. Wysocki
2009-02-04 1:02 ` [PATCH 6/7] PCI PM: Read power state from device after trying to change it on resume Rafael J. Wysocki
2009-02-04 1:09 ` [PATCH 7/7] PCI PM: Let the core be more careful with respect to drivers using new framework Rafael J. Wysocki
2009-02-04 2:05 ` Benjamin Herrenschmidt
2009-02-05 0:47 ` Rafael J. Wysocki
2009-02-05 1:18 ` Benjamin Herrenschmidt
2009-02-05 1:23 ` [PATCH 0/7] PCI PM: Fixes and refinements Jesse Barnes
2009-02-05 1:48 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233794410.4612.34.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=elendil@planet.nl \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox