Re: [PATCH 3/7] PCI PM: Fix saving of device state in pci_legacy_suspend

[Michael Ellerman <michael@ellerman.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]

On Thu, 2009-02-05 at 11:40 +1100, Benjamin Herrenschmidt wrote:
> On Wed, 2009-02-04 at 13:56 -0800, Linus Torvalds wrote:
> > 
> > On Thu, 5 Feb 2009, Benjamin Herrenschmidt wrote:
> > > 
> > > How so ? I've had such backtraces with no other info in my log...
> > 
> > _with_ that patch?
> > 
> > It very much replaces a warning with no further info with
> > 
> > +                       WARN_ONCE(pci_dev->current_state != prev,
> > +                               "PCI PM: Device state not saved by %pF\n",
> > +                               drv->suspend);
> > 
> > And notice the "%pF" and the 'drv->suspend': it should tell you exactly 
> > which suspend routine it was that messed up.
> 
> Yup, missed that change in the patch. In fact, I even missed the
> existence of a WARN_ONCE that takes those text arguments... baaaah. I
> suppose I should try to read more of lkml :-)

But don't expect to see them on powerpc, they never make it to the
console.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]