public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Jaswinder Singh Rajput <jaswinderlinux@gmail.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Sam Ravnborg <sam@ravnborg.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	hskinnemoen@atmel.com, cooloney@kernel.org, tony.luck@intel.com,
	ralf@linux-mips.org, dhowells@redhat.com, matthew@wil.cx,
	chris@zankel.net, LKML <linux-kernel@vger.kernel.org>,
	linux-next <linux-next@vger.kernel.org>,
	linux-ia64 <linux-ia64@vger.kernel.org>
Subject: Re: [linux-next][PATCH] revert headers_check fix: ia64, fpu.h
Date: Fri, 06 Feb 2009 20:59:01 +0530	[thread overview]
Message-ID: <1233934141.3209.20.camel@localhost.localdomain> (raw)
In-Reply-To: <20090206145556.GH18368@elte.hu>

On Fri, 2009-02-06 at 15:55 +0100, Ingo Molnar wrote:
> * KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> 
> > > > Index: b/arch/ia64/include/asm/fpu.h
> > > > ===================================================================
> > > > --- a/arch/ia64/include/asm/fpu.h
> > > > +++ b/arch/ia64/include/asm/fpu.h
> > > > @@ -6,7 +6,7 @@
> > > >  *     David Mosberger-Tang <davidm@hpl.hp.com>
> > > >  */
> > > >
> > > > -#include <linux/types.h>
> > > > +#include <asm/types.h>
> > > >
> > > 
> > > No , we do not even need asm/types.h
> > > 
> > > Subject: [PATCH] Neither asm/types.h nor linux/types.h is not required
> > > for arch/ia64/include/asm/fpu.h
> > > 
> > > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> > 
> > ok. I confirmed.
> > 	Tested-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> > 	Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> 
> Thanks.
> 
> Jaswinder, mind adding these tags to the commit and sending a pull request 
> with all fixes?

The following changes since commit 0b86a4e34d885e734a4c4e46293376f3f1c639eb:
  Ingo Molnar (1):
        Merge branch 'core/header-fixes' of git://git.kernel.org/.../jaswinder/linux-2.6-tip into core/header-fixes

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/linux-2.6-tip.git core/header-fixes

Jaswinder Singh Rajput (2):
      Neither asm/types.h nor linux/types.h is required for arch/ia64/include/asm/fpu.h
      make linux/types.h as assembly safe

 arch/ia64/include/asm/fpu.h |    2 --
 include/linux/types.h       |    3 ++-
 2 files changed, 2 insertions(+), 3 deletions(-)

Complete diff:
diff --git a/arch/ia64/include/asm/fpu.h b/arch/ia64/include/asm/fpu.h
index b6395ad..0c26157 100644
--- a/arch/ia64/include/asm/fpu.h
+++ b/arch/ia64/include/asm/fpu.h
@@ -6,8 +6,6 @@
  *	David Mosberger-Tang <davidm@hpl.hp.com>
  */
 
-#include <linux/types.h>
-
 /* floating point status register: */
 #define FPSR_TRAP_VD	(1 << 0)	/* invalid op trap disabled */
 #define FPSR_TRAP_DD	(1 << 1)	/* denormal trap disabled */
diff --git a/include/linux/types.h b/include/linux/types.h
index 712ca53..c30973a 100644
--- a/include/linux/types.h
+++ b/include/linux/types.h
@@ -1,6 +1,7 @@
 #ifndef _LINUX_TYPES_H
 #define _LINUX_TYPES_H
 
+#ifndef __ASSEMBLY__
 #ifdef	__KERNEL__
 
 #define DECLARE_BITMAP(name,bits) \
@@ -212,5 +213,5 @@ struct ustat {
 };
 
 #endif	/* __KERNEL__ */
-
+#endif /*  __ASSEMBLY__ */
 #endif /* _LINUX_TYPES_H */



  reply	other threads:[~2009-02-06 15:30 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-31  7:10 [git pull -tip] headers_check fixes for other architectures Jaswinder Singh Rajput
2009-01-31 16:44 ` Ingo Molnar
2009-02-01  6:30   ` Jaswinder Singh Rajput
2009-02-01 10:39     ` Ingo Molnar
2009-02-01 16:49       ` Ingo Molnar
2009-02-01 17:06         ` Russell King - ARM Linux
2009-02-01 17:20         ` Russell King - ARM Linux
2009-02-01 17:31           ` Jaswinder Singh Rajput
2009-02-01 18:33         ` Jaswinder Singh Rajput
2009-02-02 17:11         ` Mike Frysinger
2009-02-02 18:08           ` Ingo Molnar
2009-02-02 18:29             ` Mike Frysinger
2009-02-02 18:48               ` Ingo Molnar
2009-02-05 17:55 ` Tony Luck
2009-02-05 19:06   ` Linus Torvalds
2009-02-05 19:19     ` Ingo Molnar
2009-02-06  2:06       ` Jaswinder Singh Rajput
2009-02-06  2:14         ` Mike Frysinger
2009-02-06  2:20         ` Ingo Molnar
2009-02-06 14:18           ` Jaswinder Singh Rajput
2009-02-06 14:21             ` Russell King - ARM Linux
2009-02-06 14:34               ` Jaswinder Singh Rajput
2009-02-06 14:51                 ` Russell King - ARM Linux
2009-02-06 14:58                   ` Ingo Molnar
2009-02-06 15:00                   ` Jaswinder Singh Rajput
2009-02-06 15:10                     ` Russell King - ARM Linux
2009-02-06 15:56                       ` Ingo Molnar
2009-02-06 16:02                         ` Russell King - ARM Linux
2009-02-06 17:24             ` Sam Ravnborg
2009-02-06 17:40               ` Ingo Molnar
2009-02-06 18:11               ` Jaswinder Singh Rajput
2009-02-06 18:42                 ` Sam Ravnborg
2009-02-06 19:31                   ` Jaswinder Singh Rajput
2009-02-08  5:50               ` Jaswinder Singh Rajput
2009-02-09 12:23                 ` Ingo Molnar
2009-02-06  8:19 ` [linux-next][PATCH] revert headers_check fix: ia64, fpu.h KOSAKI Motohiro
2009-02-06  8:53   ` Jaswinder Singh Rajput
2009-02-06  9:11     ` KOSAKI Motohiro
2009-02-06 14:55       ` Ingo Molnar
2009-02-06 15:29         ` Jaswinder Singh Rajput [this message]
2009-02-06 15:33           ` Russell King - ARM Linux
2009-02-06 15:45             ` Ingo Molnar
2009-02-06 15:49               ` Russell King - ARM Linux
2009-02-06 16:01                 ` Ingo Molnar
2009-02-06 15:48             ` Jaswinder Singh Rajput
2009-02-06 15:55               ` Russell King - ARM Linux
2009-02-06 16:12                 ` Ingo Molnar
2009-02-06 16:23                   ` Russell King - ARM Linux
2009-02-06 16:33                     ` Ingo Molnar
2009-02-06 16:38                       ` Russell King - ARM Linux
2009-02-06 17:14                         ` Ingo Molnar
2009-02-06 17:22                           ` Russell King - ARM Linux
2009-02-06 17:32                 ` Sam Ravnborg
2009-02-06 17:41                   ` Ingo Molnar
2009-02-06 18:53     ` Luck, Tony
2009-02-06 13:42   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1233934141.3209.20.camel@localhost.localdomain \
    --to=jaswinder@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=chris@zankel.net \
    --cc=cooloney@kernel.org \
    --cc=dhowells@redhat.com \
    --cc=hskinnemoen@atmel.com \
    --cc=jaswinderlinux@gmail.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=matthew@wil.cx \
    --cc=mingo@elte.hu \
    --cc=ralf@linux-mips.org \
    --cc=sam@ravnborg.org \
    --cc=tony.luck@intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox