From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758850AbZBFTe0 (ORCPT ); Fri, 6 Feb 2009 14:34:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753362AbZBFTeS (ORCPT ); Fri, 6 Feb 2009 14:34:18 -0500 Received: from hera.kernel.org ([140.211.167.34]:48552 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753014AbZBFTeS (ORCPT ); Fri, 6 Feb 2009 14:34:18 -0500 Subject: Re: [git pull -tip] headers_check fixes for other architectures From: Jaswinder Singh Rajput To: Sam Ravnborg Cc: Ingo Molnar , Linus Torvalds , Tony Luck , Andrew Morton , Russell King - ARM Linux , hskinnemoen@atmel.com, cooloney@kernel.org, ralf@linux-mips.org, dhowells@redhat.com, matthew@wil.cx, chris@zankel.net, LKML In-Reply-To: <20090206184205.GA11879@uranus.ravnborg.org> References: <1233385816.17794.16.camel@localhost.localdomain> <12c511ca0902050955x1acb3907jdbfc1d0e6392cb91@mail.gmail.com> <20090205191907.GA27422@elte.hu> <1233886017.3463.26.camel@localhost.localdomain> <20090206022025.GA8317@elte.hu> <1233929922.3209.6.camel@localhost.localdomain> <20090206172453.GB11299@uranus.ravnborg.org> <1233943912.3209.90.camel@localhost.localdomain> <20090206184205.GA11879@uranus.ravnborg.org> Content-Type: text/plain Date: Sat, 07 Feb 2009 01:01:42 +0530 Message-Id: <1233948702.26503.8.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 (2.24.3-1.fc10) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2009-02-06 at 19:42 +0100, Sam Ravnborg wrote: > > > > Subject: [PATCH] make linux/types.h as assembly safe > > > > Signed-off-by: Jaswinder Singh Rajput > > --- > > include/linux/types.h | 6 +++++- > > 1 files changed, 5 insertions(+), 1 deletions(-) > > > > diff --git a/include/linux/types.h b/include/linux/types.h > > index 712ca53..e1322a7 100644 > > --- a/include/linux/types.h > > +++ b/include/linux/types.h > > @@ -1,6 +1,10 @@ > > #ifndef _LINUX_TYPES_H > > #define _LINUX_TYPES_H > > > > +#ifdef __ASSEMBLY__ > > +# include > > +#else /* __ASSEMBLY__ */ > > Please use: > #ifndef __ASEMBLY__ > > This is what is used in the most cases. > > And I think you need to nuke an include in the file a bit later > so we do not include asm/types.h twice. > Is this looks OK: Subject: [PATCH] make linux/types.h as assembly safe Signed-off-by: Jaswinder Singh Rajput --- include/linux/types.h | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/include/linux/types.h b/include/linux/types.h index 712ca53..6f12467 100644 --- a/include/linux/types.h +++ b/include/linux/types.h @@ -1,6 +1,10 @@ #ifndef _LINUX_TYPES_H #define _LINUX_TYPES_H +#include + +#ifndef __ASSEMBLY__ + #ifdef __KERNEL__ #define DECLARE_BITMAP(name,bits) \ @@ -9,7 +13,6 @@ #endif #include -#include #ifndef __KERNEL_STRICT_NAMES @@ -212,5 +215,5 @@ struct ustat { }; #endif /* __KERNEL__ */ - +#endif /* __ASSEMBLY__ */ #endif /* _LINUX_TYPES_H */ -- 1.6.0.6