From: Xavier Bestel <xavier.bestel@free.fr>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: "Thomas Hellström" <thomas@shipmail.org>,
"Eric Anholt" <eric@anholt.net>,
DRI <dri-devel@lists.sourceforge.net>,
"Linux Kernel" <linux-kernel@vger.kernel.org>
Subject: Re: Gem GTT mmaps..
Date: Sat, 07 Feb 2009 09:06:34 +0100 [thread overview]
Message-ID: <1233993994.5537.5.camel@badjo> (raw)
In-Reply-To: <200902061424.02906.jbarnes@virtuousgeek.org>
Le vendredi 06 février 2009 à 14:24 -0800, Jesse Barnes a écrit :
> + map = list->map;
> + if (map) {
> + drm_free(map, sizeof(*map), DRM_MEM_DRIVER);
> + list->map = NULL;
I would have inverted the two last lines (otherwise why wouldn't you
directly drw_free(list->map) ?).
Xav
next prev parent reply other threads:[~2009-02-07 8:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-04 22:32 Gem GTT mmaps Thomas Hellström
2009-02-04 23:02 ` Jesse Barnes
2009-02-04 23:42 ` Eric Anholt
2009-02-05 18:37 ` Jesse Barnes
2009-02-06 17:14 ` Jesse Barnes
2009-02-06 21:35 ` Thomas Hellström
2009-02-06 22:24 ` Jesse Barnes
2009-02-06 22:39 ` Thomas Hellström
2009-02-06 23:22 ` Jesse Barnes
2009-02-07 0:52 ` Chris Wilson
2009-02-11 22:01 ` Jesse Barnes
2009-02-07 8:06 ` Xavier Bestel [this message]
2009-02-10 22:00 ` Eric Anholt
2009-02-10 22:58 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233993994.5537.5.camel@badjo \
--to=xavier.bestel@free.fr \
--cc=dri-devel@lists.sourceforge.net \
--cc=eric@anholt.net \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas@shipmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox