Re: [PATCH] sh: maple: add support for Visual Memory Card devices, and make consequential changes to maple input drivers - 2/3 - v5

Adrian McMenamin
2009-02-09T21:43:27Z

On Mon, 2009-02-09 at 14:33 -0500, Mike Frysinger wrote:

>
> then you'd end up with 4 clearly marked files (assuming your log message for
> each change is clear). in the summary, you should then make statements like:
> Patch 1 (... subject ...) in this series can be applied by itself for the bus
> driver. Then patch 2 (... subject ...) and 3 (... subject ...) can be applied
> as they need the bus changes.
> -mike

Fair enough.

I ought to resubmit patches anyway because previous code has a memory
leak/race which I've now fixed with a couple of extra lines.

But the basic point here is that changing the bus code is necessary to
get the VMU driver (or *any* VMU driver) to work, but changing the bus
driver also breaks the two existing drivers in mainline that use the
bus. The breakage in terms of lines to be fixed is small, but it still
needs to be done 'all at once'.