Re: [PATCHSET x86/master] add stack protector support for x86_32

Tejun Heo
2009-02-10T01:37:40Z

Ingo Molnar wrote:
>> I had a patch a while back that would convert those function to take a
>> pointer to pt_regs instead of assuming that the struct was passed by
>> value. [...]
>
> Yes, that's the right solution. Getting a new call convention recognized
> is a 3 years timeframe project for a whole team of hackers. Adding a
> pointer is a 30 minutes project for one good kernel hacker ;)
>
>> [...] I'll take a stab at reworking it on top of this series.
>
> Cool!

We do add some overhead that way and Linus was against it several
years ago, so the addition of asmlinkage_protect() macros. Given that
the calling convention thing never happened through all the years and
modern machines probably wouldn't care much one way or the other, it
could just be about time to convert to pointer passing.

Thanks.

--
tejun