Re: [PATCH 03/11] x86: fix math_emu register frame access

Tejun Heo
2009-02-10T01:09:29Z

Hello, Brian.

Brian Gerst wrote:
>> {
>> printk(KERN_EMERG
>> "math-emulation not enabled and no coprocessor found.\n");
>> @@ -910,16 +910,19 @@ asmlinkage void math_emulate(long arg)
>> }
>> #endif /* CONFIG_MATH_EMULATION */
>>
>> -dotraplinkage void __kprobes
>> -do_device_not_available(struct pt_regs *regs, long error)
>> +dotraplinkage void __kprobes do_device_not_available(struct pt_regs regs)
>
> Why did you change this to pass by value? This is called from the
> generic trap handler (error_code), which already passes the pt_regs
> pointer in %eax.

Ah.. right, my bad. I somehow thought dotraplinkage is asmlinkage on
x86_32. Yeah, the original code was fine in that area, but then again
most other trap functions take struct pt_regs. Anyways, you're gonna
post patches to convert trap functions to take pointer to pt_regs,
right? Can you please fix this one up together with those?

Thanks.

--
tejun