Re: [PATCH 08/11] x86: use asm .macro instead of cpp #define in entry_32.S

Jeremy Fitzhardinge
2009-02-09T18:35:08Z

Tejun Heo wrote:
> Impact: cleanup
>
> Use .macro instead of cpp #define where approriate. This cleans up
> code and will ease future changes.
>

I agree with this in principle - cpp macros are indeed very ugly - but
in practise I've found asm macros to be very hard to work with. When
things go wrong, the gas error messages are completely useless (it only
reports the error on the line where the macro was used, without any
detail about where in the macro the problem lies), and as far as I know,
there's no way to see the source with macros expanded.

J